[PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Lukasz Majewski
lukma at denx.de
Thu Jan 11 13:18:41 CET 2024
Hi Fabio,
> Hi Fabio,
>
> > On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam <festevam at gmail.com>
> > wrote:
> > >
> > > Hi Lukasz,
> > >
> > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski <lukma at denx.de>
> > > wrote:
> > > > +serverip=10.8.217.79
> > > > +nfs_serverip=10.8.218.113
> > > > +gatewayip=10.8.209.250
> > >
> > > These IP addresses should not be hardcoded here.
> > >
> > > They were not present in xea.h originally. Please remove them.
> >
> > One more thing: xea.h had:
> > "dtbfile=imx28-xea.dtb\0"
> >
> > but I don't see dtbfile declared inside the new xea.env.
>
> Thanks for spotting it - I've forgotten to remove it after moving
> forward to fitImage.
>
> I will remove it.
>
This will be added not removed...
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240111/f3665a24/attachment.sig>
More information about the U-Boot
mailing list