[PATCH RFC 4/6] efi_selftest: Add international characters test

[Heinrich Schuchardt]

On 1/17/24 23:24, Janne Grunau via B4 Relay wrote:
> From: Andre Przywara <andre.przywara at arm.com>
>
> UEFI relies entirely on unicode output, which actual fonts displayed on
> the screen might not be ready for.
>
> Add a test displaying some international characters, to reveal missing
> glyphs, especially in our builtin fonts.

How would I detect missing Bengali and Gujarati glyphs with this test?

What might help would be an output of the Unicode entries in the font in
parallel with the glyph.

     U+0040, @
     U+0041, A
     U+0A85. અ
     U+0A86. આ
     U+0A87. ઇ
     U+0A88. ઈ
     U+0A89. ઉ

This would require some new command but not an EFI test.

Best regards

Heinrich

> This would be needed to be manually checked on the screen for
> correctness.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Suggested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Signed-off-by: Janne Grunau <j at jannau.net>
> ---
>   lib/efi_selftest/efi_selftest_textoutput.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest/efi_selftest_textoutput.c
> index cc44b38bc2..2aa81b0a80 100644
> --- a/lib/efi_selftest/efi_selftest_textoutput.c
> +++ b/lib/efi_selftest/efi_selftest_textoutput.c
> @@ -30,6 +30,9 @@ static int execute(void)
>   		0xD804, 0xDC05,
>   		0xD804, 0xDC22,
>   		0};
> +	const u16 text[] =
> +u"\u00d6sterreich Edelwei\u00df Sm\u00f8rrebr\u00f8d Sm\u00f6rg"
> +u"\u00e5s Ni\u00f1o Ren\u00e9 >\u1f19\u03bb\u03bb\u03ac\u03c2<\n";
>
>   	/* SetAttribute */
>   	efi_st_printf("\nColor palette\n");
> @@ -118,6 +121,11 @@ static int execute(void)
>   		efi_st_printf("Unicode not handled properly\n");
>   		return EFI_ST_FAILURE;
>   	}
> +	ret = con_out->output_string(con_out, text);
> +	if (ret != EFI_ST_SUCCESS) {
> +		efi_st_error("OutputString failed for international chars\n");
> +		return EFI_ST_FAILURE;
> +	}
>   	efi_st_printf("\n");
>
>   	return EFI_ST_SUCCESS;
>