[PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

Nishanth Menon nm at ti.com
Fri Jan 19 20:39:13 CET 2024


On 23:20-20240119, Apurva Nandan wrote:
> Add board files for J784S4 EVM.
> 
> SYS_DISABLE_DCACHE_OPS is selected in the Kconfig because
> J784S4/AM69 are a coherent architecture at A72 level by
> MSMC support.
> 
> Signed-off-by: Hari Nagalla <hnagalla at ti.com>
> [ add env and board specific yaml files for binman ]
Neither of them are part of this patch?
> Signed-off-by: Neha Malcom Francis <n-francis at ti.com>
> [ cleaned up the env files ]
no env file in this patch?

> Signed-off-by: Manorit Chawdhry <m-chawdhry at ti.com>
> Signed-off-by: Dasnavis Sabiya <sabiya.d at ti.com>
> Signed-off-by: Apurva Nandan <a-nandan at ti.com>
> Reviewed-by: Tom Rini <trini at konsulko.com>

[...]

> diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS
> new file mode 100644
> index 0000000000..9e0df11503
> --- /dev/null
> +++ b/board/ti/j784s4/MAINTAINERS
> @@ -0,0 +1,14 @@
> +J784S4 EVM BOARD
> +M:	Apurva Nandan <a-nandan at ti.com>
> +S:	Maintained
> +F:	board/ti/j784s4
> +F:	arch/arm/mach-k3/j784s4
> +F:	include/configs/j784s4_evm.h
> +F:	arch/arm/dts/k3-j784s4.dtsi
> +F:	arch/arm/dts/k3-j784s4-main.dtsi
> +F:	arch/arm/dts/k3-j784s4-mcu-wakeup.dtsi
> +F:	arch/arm/dts/k3-j784s4-thermal.dtsi
> +F:	arch/arm/dts/k3-j784s4-evm.dts
> +
> +AM69 SK BOARD
Don't all entries need a maintainer? I am not actually sure if the above
M will fall through for SK board.

> +F:	arch/arm/dts/k3-am69-sk.dts
> diff --git a/board/ti/j784s4/Makefile b/board/ti/j784s4/Makefile
> new file mode 100644
> index 0000000000..60161a8b5c
> --- /dev/null
> +++ b/board/ti/j784s4/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
> +#	Hari Nagalla <hnagalla at ti.com>
> +#
> +
> +obj-y += evm.o
> diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c
> new file mode 100644
> index 0000000000..5af3e21ff0
> --- /dev/null
> +++ b/board/ti/j784s4/evm.c
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Board specific initialization for J784S4 EVM
> + *
> + * Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
> + *	Hari Nagalla <hnagalla at ti.com>
> + *
> + */
> +
> +#include <image.h>
> +#include <init.h>
> +#include <spl.h>
> +#include <stdlib.h>

Are you sure we need all the above headers?

> +#include "../common/fdt_ops.h"
[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list