[PATCH 3/3] arm: mvebu: helios-4: add defconfig for spi booting

[Stefan Roese]

Hi Josua,

On 1/13/24 18:22, Tom Rini wrote:
> On Sat, Jan 13, 2024 at 05:36:57PM +0100, Josua Mayer wrote:
> 
>> Add a new defconfig based on existing helios4_config file to support
>> booting from spi flash.
>>
>> Settings for environment location are based on vendor u-boot:
>> https://github.com/kobol-io/u-boot/blob/helios4/include/configs/helios4.h#L59
>>
>> A separate defconfig is required because the options are not
>> intuitive from menuconfig, numeric values in particular.
>>
>> Signed-off-by: Josua Mayer <josua at solid-run.com>
>> ---
>>   configs/helios4_spi_defconfig | 81 +++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 81 insertions(+)
> 
> So, a super new thing that might be of interest, but please try this
> since I'd like to prove/disprove the use-case.  This could instead be:
> configs/helios4_spi_defconfig:
> #include "configs/helios4_defconfig"
> ... enable/disable options specific to the SPI boot use case ...
> 
> And so now both boards will otherwise be kept in-sync for general config
> changes.  It could further be done as:
> configs/helios4_spi_defconfig:
> #include "configs/helios4_defconfig"
> #include "board/kobol/helios4/spiboot.config"
> 
> And have board/kobol/helios4/spiboot.config contain the SPI-boot
> specific options.  This path would allow for:
> make helios4_defconfig spiboot.config
> to be a valid alternative way of configuring a build for spiboot.

That would be cool.

Still:
The current version leads to this compilation warning:

WARNING: no maintainers for 'helios4_spi'

Please fix in v2.

Thanks,
Stefan

BTW: Could you please also Cc me directly with such patches?