[PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

[Apurva Nandan]

Hi Andrew,

On 20/01/24 00:43, Andrew Davis wrote:
> On 1/19/24 11:50 AM, Apurva Nandan wrote:
>> From: Dasnavis Sabiya <sabiya.d at ti.com>
>>
>> Add config fragments for am69_sk A72 and R5 configuration.
>>
>> This applies on to:
>> j784s4_evm_a72_defconfig -> am69_sk_a72.config
>> j784s4_evm_r5_defconfig -> am69_sk_r5.config
>>
>> The usage model (with the fragment) would be:
>> make j784s4_evm_a72_defconfig am69_sk_a72.config
>> make
>>
>> OR
>>
>> make j784s4_evm_r5_defconfig am69_sk_r5.config
>> make
>>
>> Signed-off-by: Dasnavis Sabiya <sabiya.d at ti.com>
>> Signed-off-by: Apurva Nandan <a-nandan at ti.com>
>> ---
>>   board/ti/j784s4/MAINTAINERS | 2 ++
>>   configs/am69_sk_a72.config  | 5 +++++
>>   configs/am69_sk_r5.config   | 5 +++++
>>   3 files changed, 12 insertions(+)
>>   create mode 100644 configs/am69_sk_a72.config
>>   create mode 100644 configs/am69_sk_r5.config
>>
>> diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS
>> index 4433ead66b..69be13f533 100644
>> --- a/board/ti/j784s4/MAINTAINERS
>> +++ b/board/ti/j784s4/MAINTAINERS
>> @@ -20,3 +20,5 @@ AM69 SK BOARD
>>   F:    arch/arm/dts/k3-am69-sk.dts
>>   F:    arch/arm/dts/k3-am69-sk-u-boot.dtsi
>>   F:    arch/arm/dts/k3-am69-r5-sk.dts
>> +F:    configs/am69_sk_r5.config
>> +F:    configs/am69_sk_a72.config
>> diff --git a/configs/am69_sk_a72.config b/configs/am69_sk_a72.config
>> new file mode 100644
>> index 0000000000..03e74a8a56
>> --- /dev/null
>> +++ b/configs/am69_sk_a72.config
>
> Just going to ignore the comments on v7 about putting this
> in board/ti/..?
>

Sorry, somehow this got missed. Thanks for bringing up.


> Anyway, we can now do includes in defconfigs, so no config
> fragments needed, you can just add `configs/am69_evm_a72_defconfig`
> with the content:
>
> ```
> #include <configs/j784s4_evm_a72_defconfig>
>
> CONFIG_ARM=y
> CONFIG_ARCH_K3=y
> CONFIG_SOC_K3_J784S4=y
> CONFIG_TARGET_J784S4_A72_EVM=y
>
> CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk"
> CONFIG_SPL_OF_LIST="k3-am69-sk"
> CONFIG_OF_LIST="k3-am69-sk"
> ```
>
> (note we need to duplicate the _ARM/_TARGET currently to
> not confuse buildman which seems to directly parse the configs
> for arch detection).
>

I tried it, but I don't think this works as '#' signifies a comment in 
defconfig, isn't that true?


> Andrew
>
>> @@ -0,0 +1,5 @@
>> +# Defconfig fragment to apply on top of j784s4_evm_a72_defconfig
>> +
>> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk"
>> +CONFIG_SPL_OF_LIST="k3-am69-sk"
>> +CONFIG_OF_LIST="k3-am69-sk"
>> diff --git a/configs/am69_sk_r5.config b/configs/am69_sk_r5.config
>> new file mode 100644
>> index 0000000000..c42b6f3380
>> --- /dev/null
>> +++ b/configs/am69_sk_r5.config
>> @@ -0,0 +1,5 @@
>> +# Defconfig fragment to apply on top of j784s4_evm_r5_defconfig
>> +
>> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk"
>> +CONFIG_SPL_OF_LIST="k3-am69-r5-sk"
>> +CONFIG_OF_LIST="k3-am69-r5-sk"

-- 
Regards,
Apurva Nandan,
Texas Instruments.