[PATCH v3] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

Tom Rini trini at konsulko.com
Thu Jan 25 17:14:34 CET 2024


On Mon, Oct 30, 2023 at 10:34:58PM +0530, Prasanth Babu Mantena wrote:

> EEPROM detection logic in ti_i2c_eeprom_get() involves reading
> the total size and the 1-byte size with an offset 1. The commit
> 9f393a2d7af8 ("board: ti: common: board_detect: Fix EEPROM read
> quirk for 2-byte") that attempts to fix this uses a wrong pointer to
> compare.
> 
> The value with one offset is read into offset_test, but the pointer
> used to match was still ep, resulting in an invalid comparison of the
> values. The intent is to identify bad 2-byte addressing eeproms that
> get stuck on the successive reads.
> 
> Fixes: 9f393a2d7af8 (board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte)
> Signed-off-by: Prasanth Babu Mantena <p-mantena at ti.com>
> Tested-by: Matwey V. Kornilov <matwey.kornilov at gmail.com>
> Reviewed-by: Neha Malcom Francis <n-francis at ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240125/54a757ad/attachment.sig>


More information about the U-Boot mailing list