[PATCH v3 5/6] configs: enable smbios command on sandbox

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Thu Jan 25 17:26:07 CET 2024


On 25.01.24 17:14, Tom Rini wrote:
> On Thu, Jan 25, 2024 at 04:54:37PM +0100, Heinrich Schuchardt wrote:
> 
>> To make use of the Python smbios test we need the smbios command.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>> v3:
>> 	new patch
>> ---
>>   configs/sandbox_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
> 
> We should do sandbox64 too I think? Ilias was saying something I believe
> about testing one path via sandbox and another via sandbox64 (since they
> have different base dts files, putting stuff for one code path in one
> and stuff for the other in the other).

Currently the test asserts nothing that would be sandbox64 specific:

     assert 'DMI type 0,' in output
     assert 'String 1: U-Boot' in output
     assert 'DMI type 1,' in output
     assert 'Manufacturer: sandbox' in output
     assert 'DMI type 2,' in output
     assert 'DMI type 3,' in output
     assert 'DMI type 4,' in output
     assert 'DMI type 127,' in output

In a future series we might check more and then adding 
sandbox64_defconfig may make sense.

Probably this would also require providing text output for other SMBIOS 
table types.

Best regards

Heinrich



More information about the U-Boot mailing list