[PATCH 2/2] cmd: in do_efi_capsule_esrt use efi_get_configuration_table

Ilias Apalodimas ilias.apalodimas at linaro.org
Fri Jan 26 09:09:13 CET 2024


On Fri, 26 Jan 2024 at 09:54, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> Use library function efi_get_configuration_table() to find the ESRT.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  cmd/efidebug.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index a3a7556ea4a..a587860e2a5 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -173,15 +173,12 @@ EFI_ESRT_UPDATE_STATUS_NUM  > (idx) ? efi_update_status_str[(idx)] : "error"\
>  static int do_efi_capsule_esrt(struct cmd_tbl *cmdtp, int flag,
>                                int argc, char * const argv[])
>  {
> -       struct efi_system_resource_table *esrt = NULL;
> +       struct efi_system_resource_table *esrt;
>
>         if (argc != 1)
>                 return CMD_RET_USAGE;
>
> -       for (int idx = 0; idx < systab.nr_tables; idx++)
> -               if (!guidcmp(&efi_esrt_guid, &systab.tables[idx].guid))
> -                       esrt = (struct efi_system_resource_table *)systab.tables[idx].table;
> -
> +       esrt = efi_get_configuration_table(&efi_esrt_guid);
>         if (!esrt) {
>                 log_info("ESRT: table not present\n");
>                 return CMD_RET_SUCCESS;
> --
> 2.43.0
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list