[PATCH 2/5] sunxi: Enable PMIC drivevbus regulator support for USB supplies
Andre Przywara
andre.przywara at arm.com
Fri Jan 26 17:58:32 CET 2024
On Tue, 31 Oct 2023 01:39:52 -0500
Samuel Holland <samuel at sholland.org> wrote:
Hi Samuel,
> On many boards, the USB ports are powered by the PMIC's "drivevbus"
> regulator. In preparation for switching the USB PHY driver to use the
> regulator uclass instead of a virtual GPIO pin, ensure these boards
> have AXP PMIC regulator support enabled.
I am struggling for figure out how you came up with this list of boards?
Shouldn't that be all boards that use drivevbus as some USB power supply
in their DT?
However this misses some prominent cases, for instance the BananaPi M64.
It looks like every defconfig below also defines
"CONFIG_REGULATOR_AXP_USB_POWER=y", but OTOH not every user of that is
mentioned here, four boards seem to be missing?
Or is it everyone who also defines CONFIG_AXP_GPIO? Or uses
CONFIG_USB0_VBUS_PIN="AXP0-VBUS-ENABLE"?
Can you shed some light on this?
Cheers,
Andre
> Signed-off-by: Samuel Holland <samuel at sholland.org>
> ---
>
> configs/A33-OLinuXino_defconfig | 1 +
> configs/Cubieboard4_defconfig | 1 +
> configs/Cubietruck_plus_defconfig | 1 +
> configs/MSI_Primo81_defconfig | 1 +
> configs/Merrii_A80_Optimus_defconfig | 1 +
> configs/Sinovoip_BPI_M3_defconfig | 1 +
> configs/Yones_Toptech_BS1078_V2_defconfig | 1 +
> configs/colorfly_e708_q1_defconfig | 1 +
> configs/ga10h_v1_1_defconfig | 1 +
> configs/gt90h_v4_defconfig | 1 +
> configs/iNet_D978_rev2_defconfig | 1 +
> configs/inet86dz_defconfig | 1 +
> configs/inet_q972_defconfig | 1 +
> configs/polaroid_mid2407pxe03_defconfig | 1 +
> configs/polaroid_mid2809pxe04_defconfig | 1 +
> configs/q8_a23_tablet_800x480_defconfig | 1 +
> configs/q8_a33_tablet_1024x600_defconfig | 1 +
> configs/q8_a33_tablet_800x480_defconfig | 1 +
> configs/tbs_a711_defconfig | 1 +
> 19 files changed, 19 insertions(+)
>
> diff --git a/configs/A33-OLinuXino_defconfig b/configs/A33-OLinuXino_defconfig
> index df4acaf33e2..705c869c19f 100644
> --- a/configs/A33-OLinuXino_defconfig
> +++ b/configs/A33-OLinuXino_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_DCLK_PHASE=0
> CONFIG_VIDEO_LCD_BL_EN="PB2"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DCDC1_VOLT=3300
> CONFIG_USB_MUSB_HOST=y
> diff --git a/configs/Cubieboard4_defconfig b/configs/Cubieboard4_defconfig
> index d3678ad5c75..c8adabe0a0a 100644
> --- a/configs/Cubieboard4_defconfig
> +++ b/configs/Cubieboard4_defconfig
> @@ -11,5 +11,6 @@ CONFIG_USB1_VBUS_PIN="PH14"
> CONFIG_USB3_VBUS_PIN="PH15"
> CONFIG_AXP_GPIO=y
> CONFIG_SYS_I2C_SUN8I_RSB=y
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP809_POWER=y
> diff --git a/configs/Cubietruck_plus_defconfig b/configs/Cubietruck_plus_defconfig
> index 29f4df2b81c..f349d9bc49f 100644
> --- a/configs/Cubietruck_plus_defconfig
> +++ b/configs/Cubietruck_plus_defconfig
> @@ -21,6 +21,7 @@ CONFIG_SYS_I2C_SLAVE=0x7f
> CONFIG_SYS_I2C_SPEED=400000
> CONFIG_PHY_REALTEK=y
> CONFIG_SUN8I_EMAC=y
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO3_VOLT=2500
> CONFIG_AXP_DLDO4_VOLT=3300
> diff --git a/configs/MSI_Primo81_defconfig b/configs/MSI_Primo81_defconfig
> index d60eedb482a..709d27d342e 100644
> --- a/configs/MSI_Primo81_defconfig
> +++ b/configs/MSI_Primo81_defconfig
> @@ -12,6 +12,7 @@ CONFIG_VIDEO_LCD_BL_EN="PA25"
> CONFIG_VIDEO_LCD_BL_PWM="PH13"
> CONFIG_VIDEO_LCD_PANEL_MIPI_4_LANE_513_MBPS_VIA_SSD2828=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> diff --git a/configs/Merrii_A80_Optimus_defconfig b/configs/Merrii_A80_Optimus_defconfig
> index a26677e1c05..c7a3af7a8d1 100644
> --- a/configs/Merrii_A80_Optimus_defconfig
> +++ b/configs/Merrii_A80_Optimus_defconfig
> @@ -11,5 +11,6 @@ CONFIG_USB1_VBUS_PIN="PH4"
> CONFIG_USB3_VBUS_PIN="PH5"
> CONFIG_AXP_GPIO=y
> CONFIG_SYS_I2C_SUN8I_RSB=y
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP809_POWER=y
> diff --git a/configs/Sinovoip_BPI_M3_defconfig b/configs/Sinovoip_BPI_M3_defconfig
> index ad41dbd26a1..fcdd7ded82d 100644
> --- a/configs/Sinovoip_BPI_M3_defconfig
> +++ b/configs/Sinovoip_BPI_M3_defconfig
> @@ -17,6 +17,7 @@ CONFIG_CONSOLE_MUX=y
> CONFIG_PHY_REALTEK=y
> CONFIG_SUN8I_EMAC=y
> CONFIG_INITIAL_USB_SCAN_DELAY=500
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DCDC5_VOLT=1200
> CONFIG_AXP_DLDO3_VOLT=3300
> diff --git a/configs/Yones_Toptech_BS1078_V2_defconfig b/configs/Yones_Toptech_BS1078_V2_defconfig
> index de69ebe9956..67fef2a6202 100644
> --- a/configs/Yones_Toptech_BS1078_V2_defconfig
> +++ b/configs/Yones_Toptech_BS1078_V2_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_BL_EN="PA25"
> CONFIG_VIDEO_LCD_BL_PWM="PH13"
> CONFIG_VIDEO_LCD_PANEL_LVDS=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_USB_MUSB_HOST=y
> diff --git a/configs/colorfly_e708_q1_defconfig b/configs/colorfly_e708_q1_defconfig
> index 07bda049665..201b7425573 100644
> --- a/configs/colorfly_e708_q1_defconfig
> +++ b/configs/colorfly_e708_q1_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_BL_EN="PA25"
> CONFIG_VIDEO_LCD_BL_PWM="PH13"
> CONFIG_VIDEO_LCD_PANEL_LVDS=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_AXP_DLDO2_VOLT=1800
> diff --git a/configs/ga10h_v1_1_defconfig b/configs/ga10h_v1_1_defconfig
> index 935071d61ac..5d083742f1f 100644
> --- a/configs/ga10h_v1_1_defconfig
> +++ b/configs/ga10h_v1_1_defconfig
> @@ -16,6 +16,7 @@ CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> CONFIG_VIDEO_LCD_PANEL_LVDS=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/gt90h_v4_defconfig b/configs/gt90h_v4_defconfig
> index 205eab29293..6502ac8cf43 100644
> --- a/configs/gt90h_v4_defconfig
> +++ b/configs/gt90h_v4_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/iNet_D978_rev2_defconfig b/configs/iNet_D978_rev2_defconfig
> index ed6a6038424..70be98030a0 100644
> --- a/configs/iNet_D978_rev2_defconfig
> +++ b/configs/iNet_D978_rev2_defconfig
> @@ -15,6 +15,7 @@ CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> CONFIG_VIDEO_LCD_PANEL_LVDS=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> diff --git a/configs/inet86dz_defconfig b/configs/inet86dz_defconfig
> index d215a8375e2..3405bc423a3 100644
> --- a/configs/inet86dz_defconfig
> +++ b/configs/inet86dz_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/inet_q972_defconfig b/configs/inet_q972_defconfig
> index 24ff6c0062e..a70a83ebcd0 100644
> --- a/configs/inet_q972_defconfig
> +++ b/configs/inet_q972_defconfig
> @@ -13,6 +13,7 @@ CONFIG_VIDEO_LCD_DCLK_PHASE=0
> CONFIG_VIDEO_LCD_BL_EN="PA25"
> CONFIG_VIDEO_LCD_BL_PWM="PH13"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_USB_EHCI_HCD=y
> diff --git a/configs/polaroid_mid2407pxe03_defconfig b/configs/polaroid_mid2407pxe03_defconfig
> index 6ec7c83be5b..2155fe6646f 100644
> --- a/configs/polaroid_mid2407pxe03_defconfig
> +++ b/configs/polaroid_mid2407pxe03_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/polaroid_mid2809pxe04_defconfig b/configs/polaroid_mid2809pxe04_defconfig
> index 1aefc50588e..1faf78f1b54 100644
> --- a/configs/polaroid_mid2809pxe04_defconfig
> +++ b/configs/polaroid_mid2809pxe04_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/q8_a23_tablet_800x480_defconfig b/configs/q8_a23_tablet_800x480_defconfig
> index 0f8c30ec853..08ba34e08ee 100644
> --- a/configs/q8_a23_tablet_800x480_defconfig
> +++ b/configs/q8_a23_tablet_800x480_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/q8_a33_tablet_1024x600_defconfig b/configs/q8_a33_tablet_1024x600_defconfig
> index b3b5cc704f4..6efbd84f7c3 100644
> --- a/configs/q8_a33_tablet_1024x600_defconfig
> +++ b/configs/q8_a33_tablet_1024x600_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/q8_a33_tablet_800x480_defconfig b/configs/q8_a33_tablet_800x480_defconfig
> index 37ee08fa629..bf5dcd0d018 100644
> --- a/configs/q8_a33_tablet_800x480_defconfig
> +++ b/configs/q8_a33_tablet_800x480_defconfig
> @@ -14,6 +14,7 @@ CONFIG_VIDEO_LCD_POWER="PH7"
> CONFIG_VIDEO_LCD_BL_EN="PH6"
> CONFIG_VIDEO_LCD_BL_PWM="PH0"
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DLDO1_VOLT=3300
> CONFIG_CONS_INDEX=5
> diff --git a/configs/tbs_a711_defconfig b/configs/tbs_a711_defconfig
> index 9a70b6bee52..c17815382ec 100644
> --- a/configs/tbs_a711_defconfig
> +++ b/configs/tbs_a711_defconfig
> @@ -13,6 +13,7 @@ CONFIG_USB0_ID_DET="PH11"
> CONFIG_AXP_GPIO=y
> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
> +CONFIG_REGULATOR_AXP_DRIVEVBUS=y
> CONFIG_REGULATOR_AXP_USB_POWER=y
> CONFIG_AXP_DCDC5_VOLT=1200
> CONFIG_USB_EHCI_HCD=y
More information about the U-Boot
mailing list