[PATCH v4 1/3] drivers: bootcount: Add support for ANY filesystem

[Quentin Schulz]

Hi Vasileios,

On 6/28/24 7:35 PM, Vasileios Amoiridis wrote:
> Add support to save boot count variable in ANY filesystem. Tested with
> FAT and EXT.
> 
> Reviewed-by: Tom Rini <trini at konsulko.com>
> Reviewed-by: Heiko Schocher <hs at denx.de>
> Reviewed-by: Philip Oberfichtner <pro at denx.de>
> Signed-off-by: Vasileios Amoiridis <vasileios.amoiridis at cern.ch>
> ---
>   doc/README.bootcount                          | 12 +++----
>   drivers/bootcount/Kconfig                     | 36 +++++++++----------
>   drivers/bootcount/Makefile                    |  2 +-
>   .../{bootcount_ext.c => bootcount_fs.c}       | 12 +++----
>   4 files changed, 31 insertions(+), 31 deletions(-)
>   rename drivers/bootcount/{bootcount_ext.c => bootcount_fs.c} (81%)
> 
> diff --git a/doc/README.bootcount b/doc/README.bootcount
> index f6c5f82f98..0f4ffb6828 100644
> --- a/doc/README.bootcount
> +++ b/doc/README.bootcount
> @@ -23,15 +23,15 @@ It is the responsibility of some application code (typically a Linux
>   application) to reset the variable "bootcount" to 0 when the system booted
>   successfully, thus allowing for more boot cycles.
>   
> -CONFIG_BOOTCOUNT_EXT
> +CONFIG_BOOTCOUNT_FS
>   --------------------
>   
> -This adds support for maintaining boot count in a file on an EXT filesystem.
> -The file to use is defined by:
> +This adds support for maintaining boot count in a file on a filesystem.
> +Supported filesystems are FAT and EXT. The file to use is defined by:
>   
> -CONFIG_SYS_BOOTCOUNT_EXT_INTERFACE
> -CONFIG_SYS_BOOTCOUNT_EXT_DEVPART
> -CONFIG_SYS_BOOTCOUNT_EXT_NAME
> +CONFIG_SYS_BOOTCOUNT_FS_INTERFACE
> +CONFIG_SYS_BOOTCOUNT_FS_DEVPART
> +CONFIG_SYS_BOOTCOUNT_FS_NAME
>   
>   The format of the file is:
>   
> diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig
> index 3c56253b1e..fbf3c56b41 100644
> --- a/drivers/bootcount/Kconfig
> +++ b/drivers/bootcount/Kconfig
> @@ -25,13 +25,13 @@ config BOOTCOUNT_GENERIC
>   	    Set to the address where the bootcount and bootcount magic
>   	    will be stored.
>   
> -config BOOTCOUNT_EXT
> -	bool "Boot counter on EXT filesystem"
> -	depends on FS_EXT4
> -	select EXT4_WRITE
> +config BOOTCOUNT_FS
> +	bool "Boot counter on a filesystem"
>   	help
> -	  Add support for maintaining boot count in a file on an EXT
> -	  filesystem.
> +	  Add support for maintaining boot count in a file on a filesystem.
> +	  This requires that you have enabled write support for the filesystem
> +	  that you will be used by the partition that you configure this feature
> +	  for.
>   

The first "you" shouldn't be here. This could be modified when merged by 
the maintainer if they feel like it. We have many typos in different 
places and this help text is understandable with the typo/mistake, so 
**I** wouldn't send a new version just for that.

Looks good to me otherwise.
Cheers,
Quentin