[PATCH] eth: asix88179: reset during probe

Mattijs Korpershoek mkorpershoek at baylibre.com
Tue Jul 9 14:25:49 CEST 2024


Hi Marek,

On mar., juil. 09, 2024 at 13:13, Marek Vasut <marex at denx.de> wrote:

> On 7/9/24 10:39 AM, Mattijs Korpershoek wrote:
>> Hi Caleb,
>
> Hi,
>
>> Thank you for the patch.
>> 
>> On mar., juin 18, 2024 at 16:57, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>> 
>>> In some cases (consistently in my case with an embedded board) the
>>> ethernet controller will time out on the first init but always succeed
>>> after reset.
>>>
>>> Let's reset the controller during probe so we always start with it in a
>>> known state, and don't have wait for the first asix_wait_link() to
>>> time out.
>>>
>>> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
>> 
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>> 
>>> ---
>>> I see this behaviour consistently across three Qualcomm platforms that use this
>>> controller.
>>> ---
>>>   drivers/usb/eth/asix88179.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>
> Do you want to pick it via usb-gadget tree or shall I pick it via usb tree ?

According to get_maintainer.pl, it should be you :)

./scripts/get_maintainer.pl -- drivers/usb/eth/asix88179.c
Marek Vasut <marex at denx.de> (maintainer:USB)
Tom Rini <trini at konsulko.com> (maintainer:THE REST,authored:3/3=100%,added_lines:1/1=100%,removed_lines:2/2=100%)
Mattijs Korpershoek <mkorpershoek at baylibre.com> (commit_signer:1/3=33%)
u-boot at lists.denx.de (open list)

If you are okay with that, please pick it up.

Thanks!
Mattijs


More information about the U-Boot mailing list