[PATCH v2 2/2] board: rpi: remove leftover CONFIG_HW_WATCHDOG block
Peter Robinson
pbrobinson at gmail.com
Fri Jul 12 12:21:56 CEST 2024
On Fri, 12 Jul 2024 at 10:07, Rasmus Villemoes
<rasmus.villemoes at prevas.dk> wrote:
>
> This was added in commit 45a6d231b2f (bcm2835_wdt: support for the
> BCM2835/2836 watchdog), which did do 'select HW_WATCHDOG'. That
> incarnation of the watchdog driver later got removed in
> c7adc0b5f98 (watchdog: bcm2835_wdt: Remove unused BCM283x watchdog
> driver and its references), but this block was left behind.
>
> Another rpi watchdog driver has since been added, but that does not
> select HW_WATCHDOG, so this remains dead and unused. Remove it.
>
> Reviewed-by: Stefan Roese <sr at denx.de>
Thanks for the cleanup and updated commit.
Reviewed-by: Peter Robinson <pbrobinson at gmail.com>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
> board/raspberrypi/rpi/rpi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
> index d996eb0cf69..9a83cf2d6a7 100644
> --- a/board/raspberrypi/rpi/rpi.c
> +++ b/board/raspberrypi/rpi/rpi.c
> @@ -493,10 +493,6 @@ static void get_board_revision(void)
>
> int board_init(void)
> {
> -#ifdef CONFIG_HW_WATCHDOG
> - hw_watchdog_init();
> -#endif
> -
> get_board_revision();
>
> gd->bd->bi_boot_params = 0x100;
> --
> 2.45.2
>
More information about the U-Boot
mailing list