[PATCH] global_data.h: drop write-only field dm_root_f

Simon Glass sjg at chromium.org
Mon Jul 15 15:31:53 CEST 2024


On Mon, 27 May 2024 at 14:04, Rasmus Villemoes
<rasmus.villemoes at prevas.dk> wrote:
>
> The dm_root_f field seems to be entirely write-only and hence
> redundant, unless 'git grep' fails to find some access generated via
> preprocessor token concatenation or similar.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
>  common/board_r.c                  | 3 +--
>  include/asm-generic/global_data.h | 4 ----
>  test/dm/core.c                    | 1 -
>  3 files changed, 1 insertion(+), 7 deletions(-)
>

It is used for accessing the pre-relocation devices in case that is
useful / possible. But it seems that we haven't had many use cases, so
I am OK with dropping this and adding it back later if needed.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list