[PATCH] rockchip: include cru_rk3588.h and define rockchip_cru for RK3588

[FUKAUMI Naoki]

hi

On 6/19/24 05:39, FUKAUMI Naoki wrote:
 > sorry,
 >
 > On 6/19/24 05:29, FUKAUMI Naoki wrote:
 >> Hello,
 >>
 >> this happens only if HOSTCC=clang. I can see several other errors on
 >> several other targets with HOSTCC=clang.
 >
 > ^this happens only if clang is used at make foo-bar_defconfig stage.
 >
 > it seems
 >
 > make foo-bar_defconfig
 > make HOSTCC=clang CC=clang all
 >
 > works.
 >
 >> CC=clang seems to be fine.
 >>
 >> Best regards,
 >>
 >> --
 >> FUKAUMI Naoki
 >> Radxa Computer (Shenzhen) Co., Ltd.

should I check/make patches for other RK3xxx targets?
or should I avoid to use clang for defconfig?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

On 7/16/24 11:09, Kever Yang wrote:
> 
> On 2024/6/19 03:30, FUKAUMI Naoki wrote:
>> fix following error found by clang:
>>
>>    CC      arch/arm/mach-rockchip/cpu-info.o
>> arch/arm/mach-rockchip/cpu-info.c:23:13: error: incomplete definition 
>> of type 'struct rockchip_cru'
>>     23 |         switch (cru->glb_rst_st) {
>>        |                 ~~~^
>> ./arch/arm/include/asm/arch-rockchip/clock.h:181:8: note: forward 
>> declaration of 'struct rockchip_cru'
>>    181 | struct rockchip_cru;
>>        |        ^
>> 1 error generated.
>>
>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
> 
> Thanks,
> - Kever
>> ---
>>   arch/arm/include/asm/arch-rockchip/cru.h        | 2 ++
>>   arch/arm/include/asm/arch-rockchip/cru_rk3588.h | 2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-rockchip/cru.h 
>> b/arch/arm/include/asm/arch-rockchip/cru.h
>> index 9778790f34..c3259b8e7c 100644
>> --- a/arch/arm/include/asm/arch-rockchip/cru.h
>> +++ b/arch/arm/include/asm/arch-rockchip/cru.h
>> @@ -17,6 +17,8 @@
>>   # include <asm/arch-rockchip/cru_rk3399.h>
>>   #elif defined(CONFIG_ROCKCHIP_RK3568)
>>   #include <asm/arch-rockchip/cru_rk3568.h>
>> +#elif defined(CONFIG_ROCKCHIP_RK3588)
>> +#include <asm/arch-rockchip/cru_rk3588.h>
>>   #endif
>>   /* CRU_GLB_RST_ST */
>> diff --git a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h 
>> b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
>> index a0e54d3965..dad484813f 100644
>> --- a/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
>> +++ b/arch/arm/include/asm/arch-rockchip/cru_rk3588.h
>> @@ -92,6 +92,8 @@ struct rk3588_cru {
>>       unsigned int pmuclkgate_con[9]; /* Address Offset: 0x0100 */
>>   };
>> +#define rockchip_cru rk3588_cru
>> +
>>   check_member(rk3588_cru, mode_con00, 0x280);
>>   check_member(rk3588_cru, pmuclksel_con[1], 0x30304);
>