[RFC PATCH v2 09/48] lmb: remove call to lmb_init()
Sughosh Ganu
sughosh.ganu at linaro.org
Tue Jul 16 08:30:25 CEST 2024
hi Simon,
On Mon, 15 Jul 2024 at 17:09, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Sughosh,
>
> On Mon, 15 Jul 2024 at 10:31, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> >
> > hi Simon,
> >
> > On Sat, 13 Jul 2024 at 20:45, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > kHi Sughosh,
> > >
> > > On Thu, 4 Jul 2024 at 08:36, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> > > >
> > > > The LMB module will be changed to have persistent and global memory
> > > > maps of available and used memory. With this change, there won't be
> > > > any need to explicitly initialise the LMB memory maps. Remove the call
> > > > to the lmb_init() function.
> > > >
> > > > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > > > ---
> > > > Changes since V1: New patch
> > > >
> > > > arch/arm/mach-stm32mp/dram_init.c | 1 -
> > > > board/xilinx/common/board.c | 1 -
> > > > drivers/iommu/apple_dart.c | 1 -
> > > > drivers/iommu/sandbox_iommu.c | 1 -
> > > > include/lmb.h | 1 -
> > > > lib/lmb.c | 18 ------------------
> > > > test/lib/lmb.c | 18 ------------------
> > > > 7 files changed, 41 deletions(-)
> > >
> > > I can't actually find the call to lmb_init(). Where is it?
> >
> > Sorry, I do not understand this question. This patch removes the
> > lmb_init() definition, as well as calls to the function from the rest
> > of the files.
>
> I see later you add lmb_mem_regions_init() so that there are two init
> functions. We should really only have one.
Okay, let me see how I can put the functionality of lmb_init() needed
for the tests into the lmb_mem_regions_init() function.
-sughosh
>
> Regards,
> Simon
More information about the U-Boot
mailing list