[PATCH 23/24] qconfig: Move operation check into parse_args()

Simon Glass sjg at chromium.org
Wed Jul 17 17:57:11 CEST 2024


Put the check for an operation being provided into the parse_args()
function, to reduce the size of main().

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 tools/qconfig.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/tools/qconfig.py b/tools/qconfig.py
index dd24e4b398b..408807931ff 100755
--- a/tools/qconfig.py
+++ b/tools/qconfig.py
@@ -1552,7 +1552,13 @@ doc/develop/moveconfig.rst for documentation.'''
                       help='show any build errors as boards are built')
     parser.add_argument('configs', nargs='*')
 
-    return parser, parser.parse_args()
+    args = parser.parse_args()
+    if not any((args.force_sync, args.build_db, args.imply, args.find,
+                args.scan_source, args.test)):
+        parser.print_usage()
+        sys.exit(1)
+
+    return parser, args
 
 
 def imply(args):
@@ -1660,11 +1666,6 @@ def do_tests():
 def main():
     """Main program"""
     parser, args = parse_args()
-    if not any((args.force_sync, args.build_db, args.imply, args.find,
-                args.scan_source, args.test)):
-        parser.print_usage()
-        sys.exit(1)
-
     check_top_directory()
 
     # prefix the option name with CONFIG_ if missing
-- 
2.34.1



More information about the U-Boot mailing list