[PATCH v2 04/21] sandbox: Enable SPL_LOAD_BLOCK

Sean Anderson seanga2 at gmail.com
Fri Jul 19 01:58:17 CEST 2024


On 7/18/24 09:28, Sean Anderson wrote:
> On 7/13/24 03:00, Simon Glass wrote:
>> Enable this option for all sandbox boards so that the FIT-loading code
>> can be used without generating an error about block devices not being
>> supported.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> (no changes since v1)
>>
>>   common/spl/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
>> index af43b5f5d3c..970a4a346e4 100644
>> --- a/common/spl/Kconfig
>> +++ b/common/spl/Kconfig
>> @@ -288,6 +288,7 @@ config SPL_BOARD_INIT
>>   config SPL_LOAD_BLOCK
>>       bool
>> +    default y if SANDBOX
>>       help
>>         Support loading images from block devices. This adds a bl_len member
>>         to struct spl_load_info.
> 
> NACK.
> 
> Enable one of the many configs which select this one instead.
> 
> --Sean

OK, so I think you wanted to add this because of the previous patch/patch 20.

I think a better solution would be to just reduce the bl_len to 1, since unix I/O
is byte-oriented anyway and we now have several tests for bl_len != 1.

--Sean


More information about the U-Boot mailing list