[PATCH 4/4] ufs: use dcache helpers for scsi_cmd data and only invalidate if necessary
Neil Armstrong
neil.armstrong at linaro.org
Fri Jul 19 13:00:13 CEST 2024
Now we have proper flush and invalidate helpers, we can use them
directly to operate on the scsi_cmd data.
Likewise, we do not need to flush then invalidate, just flush _or_
invalidate depending on the data direction.
Signed-off-by: Neil Armstrong <neil.armstrong at linaro.org>
---
drivers/ufs/ufs.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c
index 76cda83ce81..646d4856e9c 100644
--- a/drivers/ufs/ufs.c
+++ b/drivers/ufs/ufs.c
@@ -1469,7 +1469,6 @@ static void prepare_prdt_table(struct ufs_hba *hba, struct scsi_cmd *pccb)
{
struct utp_transfer_req_desc *req_desc = hba->utrdl;
struct ufshcd_sg_entry *prd_table = hba->ucd_prdt_ptr;
- uintptr_t aaddr = (uintptr_t)(pccb->pdata) & ~(ARCH_DMA_MINALIGN - 1);
ulong datalen = pccb->datalen;
int table_length;
u8 *buf;
@@ -1481,14 +1480,10 @@ static void prepare_prdt_table(struct ufs_hba *hba, struct scsi_cmd *pccb)
return;
}
- if (pccb->dma_dir == DMA_TO_DEVICE) { /* Write to device */
- flush_dcache_range(aaddr,
- ALIGN((uintptr_t)pccb->pdata + datalen, ARCH_DMA_MINALIGN));
- }
-
- /* In any case, invalidate cache to avoid stale data in it. */
- invalidate_dcache_range(aaddr,
- ALIGN((uintptr_t)pccb->pdata + datalen, ARCH_DMA_MINALIGN));
+ if (pccb->dma_dir == DMA_TO_DEVICE)
+ ufshcd_cache_flush(pccb->pdata, datalen);
+ else
+ ufshcd_cache_invalidate(pccb->pdata, datalen);
table_length = DIV_ROUND_UP(pccb->datalen, MAX_PRDT_ENTRY);
buf = pccb->pdata;
--
2.34.1
More information about the U-Boot
mailing list