[PATCH] board: beagle: convert to CONFIG_DM_I2C

Robert Nelson robertcnelson at gmail.com
Sat Jul 20 20:08:46 CEST 2024


Thank you Anatolij, I'm really glad someone was interested in making
this board work properly in mainline u-boot!

On Sat, Jul 20, 2024 at 8:09 AM Anatolij Gustschin <agust at denx.de> wrote:
>
> Hi Simon,
>
> On Sat, 20 Jul 2024 13:36:04 +0100
> Simon Glass sjg at chromium.org wrote:
> ...
> > > -       /* return BEAGLE_NO_EEPROM if eeprom doesn't respond */
> > > -       if (i2c_probe(EXPANSION_EEPROM_I2C_ADDRESS) == 1) {
> > > -               i2c_set_bus_num(TWL4030_I2C_BUS);
> > > +       ret = i2c_get_chip_for_busnum(EXPANSION_EEPROM_I2C_BUS,
> > > +                                     EXPANSION_EEPROM_I2C_ADDRESS, 1, &eeprom);
> > > +       if (ret)
> > >                 return BEAGLE_NO_EEPROM;
> >
> > Isn't this in the devicetree? It should be possible to use
> > i2c_eeprom_read(). See for example sysinfo_rcar_probe().
>
> No, it isn't in the devicetree. This EEPROM is on an optional
> expansion board.

Oh this expansion eeprom never really supported that many devices:
https://elinux.org/Category:BeagleBoard_Expansion_Boards

With the older pre-device tree kernel days we would pass a boot arg to
the kernel to re-pinmux the proper device configuration..

We could either just drop this part, or convert to the u-boot
expansion framework, which would use u-boot overlays..

Regards,

--
Robert Nelson
https://rcn-ee.com/


More information about the U-Boot mailing list