[PATCHv1 1/2] mp: imx8m: add cpu command support

[Z.Q. Hou]

Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Friday, July 19, 2024 10:19 PM
> To: Z.Q. Hou <zhiqiang.hou at nxp.com>
> Cc: u-boot at lists.denx.de; sbabic at denx.de; dl-uboot-imx
> <uboot-imx at nxp.com>; trini at konsulko.com; Peng Fan <peng.fan at nxp.com>;
> Yi Zhao <yi.zhao at nxp.com>; Jiafei Pan <jiafei.pan at nxp.com>
> Subject: Re: [PATCHv1 1/2] mp: imx8m: add cpu command support
> 
> Hi Zhiqiang,
> 
> On Fri, Jul 19, 2024 at 11:01 AM Z.Q. Hou <zhiqiang.hou at nxp.com> wrote:
> 
> > This patch is to add the needed functions to enable cmd/mp.c, which is well
> known, so I don't think it's necessary to add an example to the commit log.
> 
> I have never used cmd/mp.c. I see several other Layerscape boards use it.
> 
> How did you test this series?
> 
> Please share more information about it in the commit log, such as the
> command line you tested, which OS was used, etc.
> 
> This is important information in the commit log as you introduce a new
> feature.
> 

Per Simon's comments, the cmd/mp.c is deprecated and I'll move to add a 'release' subcommand to the new 'cpu' command in cmd/cpu.c and will add a example in change log.

Thanks,
Zhiqiang

> 
> 
> >
> > >
> > > > --- /dev/null
> > > > +++ b/arch/arm/mach-imx/imx8m/mp.c
> > >
> > > What does mp mean?
> >
> > Short of 'multiprocessor', the same mean as cmd/mp.c.
> >
> > Thanks,
> > Zhiqiang