[PATCH v4 09/29] makefile: add mbedtls include directories

[Ilias Apalodimas]

On Thu, 18 Jul 2024 at 23:12, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> Hi Ilias,
>
> On Wed, 3 Jul 2024 at 07:35, Ilias Apalodimas <ilias.apalodimas at linaro.org> wrote:
>>
>> On Tue, 2 Jul 2024 at 21:27, Raymond Mao <raymond.mao at linaro.org> wrote:
>> >
>> > Add the mbedtls include directories into the build system.
>> >
>> > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
>> > ---
>> > Changes in v2
>> > - None.
>> > Changes in v3
>> > - Remove changes for PLATFORM_CPPFLAGS.
>> > Changes in v4
>> > - Fix errors when building without "O=".
>> > - Minor fix of the include directories.
>> >
>> >  Makefile | 6 ++++++
>> >  1 file changed, 6 insertions(+)
>> >
>> > diff --git a/Makefile b/Makefile
>> > index 07d7947c8af..fd855dbd5c9 100644
>> > --- a/Makefile
>> > +++ b/Makefile
>> > @@ -829,6 +829,12 @@ KBUILD_HOSTCFLAGS += $(if $(CONFIG_TOOLS_DEBUG),-g)
>> >  UBOOTINCLUDE    := \
>> >         -Iinclude \
>> >         $(if $(KBUILD_SRC), -I$(srctree)/include) \
>> > +       $(if $(CONFIG_MBEDTLS_LIB), \
>> > +               "-DMBEDTLS_CONFIG_FILE=\"mbedtls_def_config.h\"" \
>>
>> don't you need a full path to the config file?
>
> No, we don't need the full path.
> Since "$(srctree)/lib/mbedtls" is in the include directories, and the this filename is unique
> in the project.
>

Then why are they needed on patch #3? Don't we include them already in
the generic Makefile?

Cheers
/Ilias
> Regards,
> Raymond