[PATCH] clk: fix ccf_clk_get_rate

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Thu Jul 25 11:25:59 CEST 2024


Hi

On Thu, Jul 25, 2024 at 10:53 AM Z.Q. Hou <zhiqiang.hou at nxp.com> wrote:
>
> Hi Michael,
>
> > -----Original Message-----
> > From: Michael Nazzareno Trimarchi <michael at amarulasolutions.com>
> > Sent: Thursday, July 25, 2024 3:32 PM
> > To: Z.Q. Hou <zhiqiang.hou at nxp.com>
> > Cc: u-boot at lists.denx.de; trini at konsulko.com; lukma at denx.de;
> > seanga2 at gmail.com
> > Subject: Re: [PATCH] clk: fix ccf_clk_get_rate
> >
> > Hi
> >
> > On Thu, Jul 25, 2024 at 9:16 AM Zhiqiang Hou <Zhiqiang.Hou at nxp.com>
> > wrote:
> > >
> > > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > >
> > > As the type of return value is 'ulong', when clk_get_by_id() failed,
> > > it should return 0 to indicate the get_rate operation doesn't succeed.
> > >
> >
> > I understand your point here but the clk_get_rate that can call the ccf
> > clk_get_rate can already return -ENOSYS.
>
> will also fix it.
>

Is there any usage of the error set on the latest bit of the clock? We
need to be sure that this
is correct use accross the uboot. The clk-uclass define the error that
can return

Michael

> Thanks,
> Zhiqiang




--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com


More information about the U-Boot mailing list