[PATCH 04/40] lib: Convert str_to_list() to use alist

[Michal Simek]

On 7/25/24 16:49, Tom Rini wrote:
> On Thu, Jul 25, 2024 at 08:13:38AM +0200, Michal Simek wrote:
>>
>>
>> On 7/24/24 22:54, Tom Rini wrote:
>>> On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote:
>>>
>>>> From: Simon Glass <sjg at chromium.org>
>>>>
>>>> Use this new data structure in the utility function.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
>>>> ---
>>>>    lib/strto.c | 35 +++++++++++++++++++----------------
>>>>    1 file changed, 19 insertions(+), 16 deletions(-)
>>>
>>> This is rather big growth when we didn't already have realloc:
>>> 05: lib: Convert str_to_list() to use alist
>>>      aarch64: (for 1/1 boards) all +1765.0 rodata +37.0 text +1728.0
>>>               xilinx_versal_mini_emmc0: all +1765 rodata +37 text +1728
>>>                  u-boot: add: 7/0, grow: 1/0 bytes: 1728/0 (1728)
>>>                    function                                   old     new   delta
>>>                    realloc                                      -    1120   +1120
>>>                    alist_ensure_ptr                             -     140    +140
>>>                    alist_expand_to                              -     136    +136
>>>                    alist_init                                   -     108    +108
>>>                    alist_uninit_move_ptr                        -      76     +76
>>>                    alist_add_ptr                                -      72     +72
>>>                    alist_uninit                                 -      48     +48
>>>                    str_to_list                                204     232     +28
>>>
>>
>> this is definitely not acceptable. This mini configuration is running out of
>> OCM and we are already pretty close to limit.
>>
>> What's the reason for this change? I can't see any explanation in commit message.
> 
> It was more clearly explained in the cover thread for when Simon posted
> alist. This conversion was an example, so dropping it from the lmb
> rework series is fine.

Perfect. We will also extend our configurations to have limit setup.

Thanks,
Michal