[PATCH 36/40] test: lmb: add a separate class of unit tests for lmb

Simon Glass sjg at chromium.org
Fri Jul 26 01:32:57 CEST 2024


Hi Sughosh,

On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
>
> Add the LMB unit tests under a separate class of tests. The LMB tests
> involve changing the LMB's memory map. With the memory map now
> persistent and global, running these tests has a side effect and
> impact any subsequent tests. Run these tests separately so that the
> system can be reset on completion of these tests.
>

This is just not a good idea...we should fix the tests so they don't
have these side effects.

> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> ---
> Changes since rfc: None
>
>  include/test/suites.h        |  1 +
>  test/Kconfig                 |  9 ++++++
>  test/Makefile                |  1 +
>  test/cmd_ut.c                |  7 +++++
>  test/lib/Makefile            |  1 -
>  test/{lib/lmb.c => lmb_ut.c} | 53 ++++++++++++++++++++++--------------
>  6 files changed, 50 insertions(+), 22 deletions(-)
>  rename test/{lib/lmb.c => lmb_ut.c} (93%)

Regards,
Simon


More information about the U-Boot mailing list