[PATCH 33/40] test: cedit: use allocated address for reading file
Sughosh Ganu
sughosh.ganu at linaro.org
Mon Jul 29 10:53:03 CEST 2024
On Fri, 26 Jul 2024 at 05:02, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Sughosh,
>
> On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> >
> > Instead of a randomly selected address, use an LMB allocated one for
> > reading the file into memory. With the LMB map now being persistent
> > and global, the address used for reading the file might be already
> > allocated as non-overwritable, resulting in a failure. Get a valid
> > address from LMB and then read the file to that address.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > ---
> > Changes since rfc: None
> >
> > test/boot/cedit.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
>
> No, we should not start putting lmb into tests like this.
The test fails if the address is not allocated through an lmb api.
Although I can check why.
-sughosh
>
> Regards,
> Simon
More information about the U-Boot
mailing list