[PATCH 40/40] lmb: ut: re-enable unit tests

[Sughosh Ganu]

On Fri, 26 Jul 2024 at 05:03, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Sughosh,
>
> On Wed, 24 Jul 2024 at 00:06, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> >
> > All the changes needed for making the LMB memory map persistent and
> > global have been made, including making corresponding changes in the
> > test code. Re-enable the unit tests on the platforms.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > ---
> > Changes since rfc: New patch
> >
> >  configs/sandbox64_defconfig        | 4 +++-
> >  configs/sandbox_defconfig          | 7 +++----
> >  configs/sandbox_flattree_defconfig | 4 +++-
> >  configs/sandbox_noinst_defconfig   | 8 ++++----
> >  configs/sandbox_spl_defconfig      | 8 ++++----
> >  configs/sandbox_vpl_defconfig      | 6 ++++--
> >  configs/snow_defconfig             | 2 +-
> >  7 files changed, 22 insertions(+), 17 deletions(-)
>
> It would be much better to change the tests as needed, so they keep passing.

What issue do you see with this approach? If I have to do what you
suggest, I will have to put all the test related changes as part of
the same commit which makes the LMB map persistent and global. I have
seen this kind of approach taken elsewhere, so really not sure what is
the problem with this.

-sughosh

>
> Regards,
> Simon