[PATCH 06/35] arm: friendlyarm: Avoid accessing global_data fb_base

Stefan Bosch stefan_b at posteo.net
Mon Jul 29 19:57:32 CEST 2024


Hi Simon,

On 24.07.24 17:08, Simon Glass wrote:
> Use the new video function to get the framebuffer base.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---

Tested-by: Stefan Bosch <stefan_b at posteo.net>

Looks OK, tested on FriendlyElec-Board NanoPC-T2 
(s5p4418_nanopi2_defconfig).

Thanks!

> 
>   board/friendlyarm/nanopi2/board.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/board/friendlyarm/nanopi2/board.c b/board/friendlyarm/nanopi2/board.c
> index c8cbc5a15fa..b32dfc6b570 100644
> --- a/board/friendlyarm/nanopi2/board.c
> +++ b/board/friendlyarm/nanopi2/board.c
> @@ -11,6 +11,7 @@
>   #ifdef CONFIG_PWM_NX
>   #include <pwm.h>
>   #endif
> +#include <video.h>
>   #include <asm/global_data.h>
>   #include <asm/io.h>
>   
> @@ -492,12 +493,8 @@ int splash_screen_prepare(void)
>   					 ARRAY_SIZE(splash_locations));
>   	}
>   
> -	if (!err) {
> -		char addr[64];
> -
> -		sprintf(addr, "0x%lx", gd->fb_base);
> -		env_set("fb_addr", addr);
> -	}
> +	if (!err)
> +		env_set_hex("fb_addr", video_get_fb());
>   
>   	return err;
>   }

Regards,
Stefan


More information about the U-Boot mailing list