[PATCH v4 25/29] mbedtls: add RSA helper layer on MbedTLS

[Raymond Mao]

Hi Ilias,

On Tue, 30 Jul 2024 at 04:05, Ilias Apalodimas <ilias.apalodimas at linaro.org>
wrote:

> Hi Raymond
>
>
> On Tue, 2 Jul 2024 at 21:33, Raymond Mao <raymond.mao at linaro.org> wrote:
> >
> > Add RSA helper layer on top on MbedTLS PK and RSA library.
> > Introduce _LEGACY and _MBEDTLS kconfigs for RSA helper legacy and
> > MbedTLS implementations respectively.
> >
> > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> > ---
> > Changes in v2
> > - Initial patch.
> > Changes in v3
> > - None.
> > Changes in v4
> > - Introduce _LEGACY and _MBEDTLS kconfigs for RSA helper legacy and
> >   MbedTLS implementations respectively.
> > - Remove unnecessary type casting.
> > - Minor fix of the include directories.
> >
> >  lib/mbedtls/Kconfig      | 36 +++++++++++++++
> >  lib/mbedtls/Makefile     |  3 +-
> >  lib/mbedtls/rsa_helper.c | 95 ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 133 insertions(+), 1 deletion(-)
> >  create mode 100644 lib/mbedtls/rsa_helper.c
> >
> > diff --git a/lib/mbedtls/Kconfig b/lib/mbedtls/Kconfig
> > index d8a8f87e031..87c500d6ca9 100644
> > --- a/lib/mbedtls/Kconfig
> > +++ b/lib/mbedtls/Kconfig
> > @@ -124,11 +124,13 @@ config LEGACY_CRYPTO_CERT
> >         bool "legacy certificate libraries"
> >         select ASYMMETRIC_PUBLIC_KEY_SUBTYPE_LEGACY if \
> >                 ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> > +       select RSA_PUBLIC_KEY_PARSER_LEGACY if RSA_PUBLIC_KEY_PARSER
> >         select X509_CERTIFICATE_PARSER_LEGACY if X509_CERTIFICATE_PARSER
> >         select PKCS7_MESSAGE_PARSER_LEGACY if PKCS7_MESSAGE_PARSER
> >         select MSCODE_PARSER_LEGACY if MSCODE_PARSER
> >         select SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE_LEGACY if \
> >                 ASYMMETRIC_PUBLIC_KEY_SUBTYPE && SPL
> > +       select SPL_RSA_PUBLIC_KEY_PARSER_LEGACY if RSA_PUBLIC_KEY_PARSER
> && SPL
>
> SPL shouldn't be selected. IIRC we discussed the same thing on another
> patch, so I assume this is fixed already?
>
> Yes. It is already fixed in the upcoming v5 as below:
```
select SPL_ASN1_DECODER_LEGACY if SPL_ASN1_DECODER
select SPL_ASYMMETRIC_PUBLIC_KEY_LEGACY if \
SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE
select SPL_RSA_PUBLIC_KEY_PARSER_LEGACY if SPL_RSA_PUBLIC_KEY_PARSER
```

Regards,
Raymond