[PATCH v2 0/4] arm: Add Analog Devices SC5xx Machine Type
Tom Rini
trini at konsulko.com
Sat May 4 00:20:42 CEST 2024
On Wed, Apr 24, 2024 at 08:03:59PM -0400, Greg Malysa wrote:
> This series adds support for the ADI SC5xx machine type and includes two
> core drivers that are required for being able to boot any board--a UART
> driver, the gptimer driver which is used as a clock reference (CNTVCNT
> is not supported on the armv7 sc5xx SoCs) and the clock tree driver. Our
> corresponding Linux support relies on u-boot configuring the clocks
> correctly before booting, so it is not possible to boot any board
> without the CGU/CDU configuration happening here. There are also no
> board files, device trees, or defconfigs included here, but some common
> definitions that will be used to build board files currently are. The
> sc5xx SoCs themselves include many armv7 families (sc57x, sc58x, and
> sc594) all using an ARM Cortex-A5, and one armv8 family (sc598) indended
> to be a drop-in replacement for the SC594 in terms of peripherals, with
> a Cortex-A55 instead.
>
> Some of the configuration code in dmcinit and clkinit is quite scary and
> causes a lot of checkpatch violations. It is modified from code
> initially provided by ADI, but it has not been fully rewritten. There's
> a question of how important it is to clean up this code--it has some
> quality violations, but it has been in use (including in production) for
> over two years and is known to work for performing the low level SoC
> initialization, while a rewrite might introduce timing or sequence bugs
> that could take a significant amount of time to detect in the future.
I gave the series a cursory look, and CI is also happy. I will put this
in to the -next branch sometime soon after it opens, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240503/95421d28/attachment.sig>
More information about the U-Boot
mailing list