[PATCH v2 03/28] mbedtls: add mbedtls into the build system

Tom Rini trini at konsulko.com
Thu May 9 17:11:33 CEST 2024


On Thu, May 09, 2024 at 11:04:07AM -0400, Raymond Mao wrote:
> Hi Tom,
> 
> On Tue, 7 May 2024 at 17:16, Tom Rini <trini at konsulko.com> wrote:
> 
> > On Tue, May 07, 2024 at 10:50:45AM -0700, Raymond Mao wrote:
> >
> > > Port mbedtls with dummy libc header files.
> > > Add mbedtls default config header file.
> > > Optimize mbedtls default config by disabling unused features to
> > > reduce the target size.
> > > Add mbedtls kbuild makefile.
> > > Add Kconfig and mbedtls config submenu.
> > [snip]
> > > diff --git a/include/stdio.h b/include/stdio.h
> > > index 3241e2d493f..874279c60dd 100644
> > > --- a/include/stdio.h
> > > +++ b/include/stdio.h
> > > @@ -3,6 +3,7 @@
> > >
> > >  #include <stdarg.h>
> > >  #include <linux/compiler.h>
> > > +#include <vsprintf.h>
> > >
> > >  /* stdin */
> > >  int getchar(void);
> >
> > Is this really needed? I know our include structure is a bit odd. Should
> > we perhaps look at moving a prototype or two around to be more broadly
> > compatible?
> >
> Then we need to move  prototypes of snprintf, _vprintf, putc_outstr and
> printf_info from tiny-printf to stdio.h. Is this good for you?

I don't quite follow you but yes, please work it up for review at least
as I'm not too thrilled with adding <vsprintf.h> to <stdio.h> after the
work I did removing <common.h> showed some fun around those headers as
well, and I'd like to sort it out correctly.  Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240509/5efa5ee2/attachment.sig>


More information about the U-Boot mailing list