[PATCH] boot: image-board: Mismatch a type between variable and return value

[Marek Vasut]

On 11/6/24 12:47 AM, Jaehoon Chung wrote:
> 
>> -----Original Message-----
>> From: Marek Vasut <marek.vasut at mailbox.org>
>> Sent: Wednesday, November 6, 2024 7:57 AM
>> To: Jaehoon Chung <jh80.chung at samsung.com>; u-boot at lists.denx.de
>> Cc: trini at konsulko.com; sjg at chromium.org; marek.vasut+renesas at mailbox.org;
>> laurent.pinchart at ideasonboard.com; m.szyprowski at samsung.com
>> Subject: Re: [PATCH] boot: image-board: Mismatch a type between variable and return value
>>
>> On 11/5/24 11:11 PM, Jaehoon Chung wrote:
>>> phys_addr_t can be used unsigned long long type with CONFIG_PHYS_64BIT.
>>> But hextoul() is always returning to unsigned long. It can be assigned
>>> to unexpected value. To avoid wrong behavior, change from hextoul() to
>>> simple_strtoull().
>>>
>>> Fixes: a4df06e41fa2 ("boot: fdt: Change type of env_get_bootm_low() to phys_addr_t")
>>
>> Looking at:
>>
>> 7e5f460ec457 ("global: Convert simple_strtoul() with hex to hextoul()")
> 
> Thanks for informing it.
> 
>>
>> do you have to update any of the other hextoul() calls too ?
> 
> I didn't check other hextoul().
> During booting with initramfs on RPi (32bit), I found the problem that is not working fine because of this.

Please check the other sites too, maybe there are more of these issues 
lurking around.

>> Maybe we need hextoull() ?
> 
> IMO, We need hextoull() for some cases.
> If there is no objection, I will send the patch for adding hextoull().
> And I will check entire cases.
No objection from me. Thank you.