[PATCH v1 2/3] usb: tcpm: fusb302: add support for set_vbus() callback.

Maxim Kiselev bigunclemax at gmail.com
Wed Nov 6 17:10:21 CET 2024


Hi, Sebastian, Jonas

Thanks for your suggestions.
I'll fix it in v2.

вс, 3 нояб. 2024 г. в 02:22, Jonas Karlman <jonas at kwiboo.se>:
> >> +            chip->vbus_on = on;
>
> vbus_on could probably be dropped, fixed and gpio regulators is
> currently already reference counted. Or is the set_vbus ops not called
> evenly and current state needs to be known?

Yep, vbus_on could be dropped. It is only necessary to display dev_dbg messages,
which are similar to Linux fusb302_log.

So, do you suggest removing this?

Best wishes,
Maksim


More information about the U-Boot mailing list