[PATCH v3 4/6] net: lwip: Enable https:// support for wget

Simon Glass sjg at chromium.org
Mon Nov 11 14:03:27 CET 2024


On Sun, 10 Nov 2024 at 01:32, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
> With the recent changes of lwip & mbedTLS we can now download from
> https:// urls instead of just http://.
> Adjust our wget lwip version parsing to support both URLs.
> While at it adjust the default TCP window for QEMU since https seems to
> require at least 16384
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> ---
>  cmd/Kconfig      | 19 +++++++++++
>  net/lwip/Kconfig |  2 +-
>  net/lwip/wget.c  | 86 +++++++++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 97 insertions(+), 10 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

Some nits / questions

I am not sure what mbedtls_hardware_poll() is, but if @len is too
short, would it be acceptable to return an error? How many bytes is it
requesting in the https case?

uclass_first_device() if you want the first device, not uclass_get_device(...0)

Regards,
Simon


More information about the U-Boot mailing list