[PATCH v13 3/7] usb: onboard-hub: add support for Microchip USB5744

[Abbarapu, Venkatesh]

> -----Original Message-----
> From: Marek Vasut <marex at denx.de>
> Sent: Monday, November 18, 2024 6:49 PM
> To: Abbarapu, Venkatesh <venkatesh.abbarapu at amd.com>; u-boot at lists.denx.de
> Cc: Simek, Michal <michal.simek at amd.com>; fabrice.gasnier at foss.st.com; git
> (AMD-Xilinx) <git at amd.com>
> Subject: Re: [PATCH v13 3/7] usb: onboard-hub: add support for Microchip
> USB5744
> 
> On 11/18/24 11:07 AM, Venkatesh Yadav Abbarapu wrote:
> > Add support for the Microchip USB5744 USB3.0 and USB2.0 Hub.
> > The usb5744 driver trigger hub reset signal after soft reset.
> > The usb5744 hub need to reset after the phy initialization, which
> > toggles the gpio.
> >
> > Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> > Reviewed-by: Marek Vasut <marex at denx.de>
> > ---
> >   common/usb_onboard_hub.c | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/common/usb_onboard_hub.c b/common/usb_onboard_hub.c index
> > 812e7749de..4860de5323 100644
> > --- a/common/usb_onboard_hub.c
> > +++ b/common/usb_onboard_hub.c
> > @@ -93,10 +93,21 @@ static const struct onboard_hub_data usb2514_data = {
> >   	.reset_us = 1,
> >   };
> >
> > +static const struct onboard_hub_data usb5744_data = {
> > +	.power_on_delay_us = 1000,
> > +	.reset_us = 5,
> > +};
> > +
> >   static const struct udevice_id usb_onboard_hub_ids[] = {
> >   	/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
> >   	{	.compatible = "usb424,2514",	/* USB2514B USB 2.0 */
> >   		.data = (ulong)&usb2514_data,
> > +	}, {
> > +		.compatible = "usb424,2744",	/* USB2744 USB 2.0 */
> > +		.data = (ulong)&usb5744_data,
> > +	}, {
> > +		.compatible = "usb424,5744",	/* USB5744 USB 3.0 */
> > +		.data = (ulong)&usb5744_data,
> >   	}
> >   };
> Let's finish the ongoing discussion in
> 
> Re: [PATCH v11 3/7] usb: onboard-hub: add support for Microchip USB5744
> 
> In the meantime, no need to send new versions of the series.
> 
> I retract my RB on this patch until the discussion is concluded too.

Sure...Thanks.