[PATCH v3 5/5] configs: j7200_evm_r5_defconfig: Define K3_OPP_LOW

[Limaye, Aniket]

On 11/18/2024 10:54 AM, Manorit Chawdhry wrote:
> Hi Aniket,
> 
> On 12:45-20241116, Aniket Limaye wrote:
>> From: Reid Tonking <reidt at ti.com>
>>
>> Define new CONFIG_K3_OPP_LOW under arm/mach-k3/Kconfig and add default
>> value to j7200_evm_r5_defconfig
>>
>> Signed-off-by: Reid Tonking <reidt at ti.com>
>> Signed-off-by: Aniket Limaye <a-limaye at ti.com>
>>
>> ---
>> v3:
>> - Add Kconfig dependency on K3_AVS0
>> - Update commit msg to make it more clear
>> - Link to v2: https://lore.kernel.org/u-boot/20241023130033.1826413-6-a-limaye@ti.com/
>>
>> Signed-off-by: Aniket Limaye <a-limaye at ti.com>
>> ---
>>   arch/arm/mach-k3/Kconfig       | 7 +++++++
> 
> Should this be in mach-k3/r5/Kconfig?
> 

Yeah makes sense to have it under mach-k3/r5/

>>   configs/j7200_evm_r5_defconfig | 1 +
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig
>> index f3f42b39213..c73396bfbf3 100644
>> --- a/arch/arm/mach-k3/Kconfig
>> +++ b/arch/arm/mach-k3/Kconfig
>> @@ -103,6 +103,13 @@ config SYS_K3_BOOT_CORE_ID
>>   	int
>>   	default 16
>>   
>> +config K3_OPP_LOW
>> +	depends on ARCH_K3 && K3_AVS0
>> +	bool "Enable OPP_LOW on supported TI K3 SoCs"
>> +	help
>> +	  Enabling this will allow Socs with the proper efuse to run at a lower
>> +	  MPU core voltage and adjust frequency according to SoC trm
> 
> nit: s/trm/TRM

Noted

Thanks for the detailed reviews!

Regards,
Aniket

> 
>> +
>>   config K3_EARLY_CONS
>>   	bool "Activate to allow for an early console during SPL"
>>   	depends on SPL
>> diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig
>> index f036a6fd46b..217759e5d1b 100644
>> --- a/configs/j7200_evm_r5_defconfig
>> +++ b/configs/j7200_evm_r5_defconfig
>> @@ -102,6 +102,7 @@ CONFIG_K3_SEC_PROXY=y
>>   CONFIG_FS_LOADER=y
>>   CONFIG_SPL_FS_LOADER=y
>>   CONFIG_K3_AVS0=y
>> +# CONFIG_K3_OPP_LOW is not set
>>   CONFIG_SUPPORT_EMMC_BOOT=y
>>   CONFIG_SPL_MMC_HS400_SUPPORT=y
>>   CONFIG_MMC_SDHCI=y
>> -- 
>> 2.47.0
>>