[PATCH 0/5] collected fallout of porting an ATSAMA5D2 based board

[Michael Nazzareno Trimarchi]

HI all

On Tue, Nov 19, 2024 at 4:46 PM Eugen Hristev <eugen.hristev at linaro.org> wrote:
>
>
>
> On 11/12/24 15:45, Eugen Hristev wrote:
> >
> >
> > On 10/18/24 11:30, Benedikt Spranger wrote:
> >> Hi,
> >>
> >> while porting an ATSAMA5D2 based board (booting from NAND flash with UBI)
> >> I stumbled over generic, NAND- and UBI related asperity:
> >>
> >> 1. tiny-printf does not handle NULL arguments to '%s' in a proper way
> >> 2. vtbl_check() has an useless debug output due to a typo
> >> 3. NAND: An informative output fails badly, if the NAND vendor is unknown
> >> 4. the nand_atmel driver lacks a vital initialisation
> >>
> >> OK, you might say the nand_atmel NAND driver is obsolete, but it was the
> >> only solution to get booting from NAND running. The new DM based NAND driver
> >> refused to do anything usefull, so I dropped it after spending a couple of
> >> days debugging it:
> >>
> >> <RANT>brilliant!</RANT>
> >>

I totally missed those patches. I'm really concerned about it. I will
review the respin

Michael

> >> regards
> >>     Benedikt Spranger
> >>
> >> Benedikt Spranger (5):
> >>   tiny-printf: Handle NULL pointer argument to %s
> >>   drivers/mtd/ubispl/ubispl.c: Fix error message
> >>   mtd: nand: raw: Fix potential NULL pointer dereference
> >>   mtd: nand: Update NAND manufacturer Ids
> >>   mtd: nand: raw: atmel_nand: Add missing nand_scan_ident()
> >>
> >>  drivers/mtd/nand/raw/atmel_nand.c |  4 ++++
> >>  drivers/mtd/nand/raw/nand_base.c  |  8 ++++----
> >>  drivers/mtd/nand/raw/nand_ids.c   | 22 ++++++++++++----------
> >>  drivers/mtd/ubispl/ubispl.c       |  2 +-
> >>  include/linux/mtd/rawnand.h       | 23 +++++++++++++----------
> >>  lib/tiny-printf.c                 |  2 +-
> >>  6 files changed, 35 insertions(+), 26 deletions(-)
> >>
> >
> > Coming back to these patches I had a look and except a typo , it looks good.
> > I can take these through at91 tree or maybe Michael you want to have a
> > look as they touch the MTD/NAND drivers ?
> >
> > Thanks,
> > Eugen
>
>
> I have applied patches 1 and 2 to u-boot-at91/next .
> The other three would need a resubmit .
>
> Eugen



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com