[PATCH v1] imx: Kconfig: make IMX8_ROMAPI configurable

[Peng Fan]

> Subject: Re: [PATCH v1] imx: Kconfig: make IMX8_ROMAPI
> configurable
> 
> On Tue, Oct 08, 2024 at 08:54:38AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH v1] imx: Kconfig: make IMX8_ROMAPI
> configurable
> > >
> > > On Mon, Oct 07, 2024 at 11:46:03AM +0000, Peng Fan wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Tom Rini <trini at konsulko.com>
> > > > > Sent: Monday, October 7, 2024 6:51 AM
> > > > > To: Marek Vasut <marex at denx.de>
> > > > > Cc: Alice Guo (OSS) <alice.guo at oss.nxp.com>; u-
> > > boot at lists.denx.de;
> > > > > sbabic at denx.de; festevam at gmail.com; dl-uboot-imx <uboot-
> > > > > imx at nxp.com>; Peng Fan <peng.fan at nxp.com>; Ross, Fedor
> > > > > <fedor.ross at ifm.com>; Ye Li <ye.li at nxp.com>;
> > > seanga2 at gmail.com;
> > > > > Alice Guo <alice.guo at nxp.com>
> > > > > Subject: Re: [PATCH v1] imx: Kconfig: make IMX8_ROMAPI
> > > configurable
> > > > >
> > > > > On Mon, Oct 07, 2024 at 12:28:44AM +0200, Marek Vasut
> wrote:
> > > > > > On 10/6/24 11:23 PM, Tom Rini wrote:
> > > > > > > On Sun, Oct 06, 2024 at 07:31:16AM +0800,
> > > > > alice.guo at oss.nxp.com wrote:
> > > > > > >
> > > > > > > > From: Peng Fan <peng.fan at nxp.com>
> > > > > > > >
> > > > > > > > Make CONFIG_IMX8_ROMAPI could be configured in
> > > defconfig.
> > > > > > > >
> > > > > > > > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > > > > > > > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > > > > > > > Reviewed-by: Ye Li <ye.li at nxp.com>
> > > > > > > > ---
> > > > > > > >   arch/arm/mach-imx/Kconfig | 3 ++-
> > > > > > > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > >
> > > > > > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-
> > > > > imx/Kconfig
> > > > > > > > index 134e42028c..9d3aafd2f8 100644
> > > > > > > > --- a/arch/arm/mach-imx/Kconfig
> > > > > > > > +++ b/arch/arm/mach-imx/Kconfig
> > > > > > > > @@ -179,7 +179,8 @@ config
> DDRMC_VF610_CALIBRATION
> > > > > > > >   	  the ddrmc_cr_setting on relevant board file.
> > > > > > > >   config IMX8_ROMAPI
> > > > > > > > -	def_bool y
> > > > > > > > +	bool "Enable i.MX ROMAPI"
> > > > > > > > +	default y
> > > > > > > >   	depends on IMX8MN || IMX8MP || IMX8ULP ||
> > > IMX9
> > > > > > >
> > > > > > > Since there's no help here, is this truly configurable, or
> > > > > > > is this something that should be select'd based on the SoC
> > > > > > > and
> > > > > presumably
> > > > > > > some of the newer IMX9 parts cannot use this?
> > > > > > I can imagine the MX95 calls into this custom ELE firmware
> > > > > > stuff instead of ROMAPI ?
> > > > >
> > > > > Alright. Perhaps this should be depending on the above and
> > > > > !main-ELE- symbol instead.
> > > >
> > > > Nope. To i.MX93, ELE and ROMAPI are both valid. There is case
> that
> > > > ROMAPI needs to be false while ELE is still true.
> > >
> > > Alright, but where is the choice made? As in, can a normal i.MX93
> > > board use one or the other, or will it depend on specific SoCs in
> > > the family?
> > > And is disabling this option even valid on the i.MX8 families?
> >
> > Sorry, my last statement was wrong. This is only to disable ROMAPI
> for
> > i.MX95. Downstream only has below:
> > ./configs/imx95_19x19_evk_lvds_defconfig:222:CONFIG_IMX8_ROM
> API=n
> > ./configs/imx95_19x19_verdin_android_trusty_defconfig:221:CONFI
> G_IMX8_
> > ROMAPI=n
> > ./configs/imx95_15x15_evk_android_dual_defconfig:217:CONFIG_IM
> X8_ROMAP
> >
> I=n ./configs/imx95_19x19_evk_defconfig:222:CONFIG_IMX8_ROMAPI
> =n
> > ./configs/imx95_19x19_evk_android_uuu_defconfig:222:CONFIG_IM
> X8_ROMAPI
> > =n
> > ./configs/imx95_19x19_verdin_fspi_defconfig:226:CONFIG_IMX8_RO
> MAPI=n
> > ./configs/imx95_19x19_evk_android_dual_defconfig:222:CONFIG_IM
> X8_ROMAP
> >
> I=n ./configs/imx95_15x15_evk_defconfig:217:CONFIG_IMX8_ROMAPI
> =n
> > ./configs/imx95_15x15_evk_android_uuu_defconfig:217:CONFIG_IM
> X8_ROMAPI
> > =n
> > ./configs/imx95_19x19_evk_android_trusty_secure_unlock_dual_def
> config:
> > 222:CONFIG_IMX8_ROMAPI=n
> > ./configs/imx95_19x19_verdin_android_uuu_defconfig:221:CONFIG_
> IMX8_ROM
> > API=n
> > ./configs/imx95_15x15_evk_lvds_defconfig:218:CONFIG_IMX8_ROM
> API=n
> > ./configs/imx95_19x19_verdin_android_trusty_dual_defconfig:221:C
> ONFIG_
> > IMX8_ROMAPI=n
> > ./configs/imx95_19x19_verdin_defconfig:221:CONFIG_IMX8_ROMAP
> I=n
> > ./configs/imx95_15x15_evk_android_trusty_dual_defconfig:217:CON
> FIG_IMX
> > 8_ROMAPI=n
> > ./configs/imx95_15x15_evk_android_defconfig:217:CONFIG_IMX8_R
> OMAPI=n
> > ./configs/imx95_19x19_evk_android_rpmsg_defconfig:222:CONFIG_I
> MX8_ROMA
> > PI=n
> > ./configs/imx95_19x19_evk_android_trusty_defconfig:222:CONFIG_I
> MX8_ROM
> > API=n
> > ./configs/imx95_19x19_evk_fspi_defconfig:227:CONFIG_IMX8_ROM
> API=n
> > ./configs/imx95_19x19_evk_android_defconfig:222:CONFIG_IMX8_R
> OMAPI=n
> > ./configs/imx95_19x19_evk_android_trusty_dual_defconfig:222:CON
> FIG_IMX
> > 8_ROMAPI=n
> > ./configs/imx95_19x19_verdin_android_defconfig:221:CONFIG_IMX8
> _ROMAPI=
> > n
> 
> So it sounds like this is not something to be prompted for and must be
> selected / def_bool'd appropriately.

Yeah, change to the following should be fine as of now and put this
into the i.MX95 patchset.

config IMX8_ROMAPI
-       def_bool y
+       def_bool y if (!IMX95)

Thanks,
Peng.

> 
> --
> Tom