[PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433

Kever Yang kever.yang at rock-chips.com
Fri Oct 25 14:00:18 CEST 2024


On 2024/10/14 03:24, Heiko Stuebner wrote:
> From: Uwe Kleine-König <ukleinek at debian.org>
>
> While it requires to have the right phy driver loaded (i.e. motorcomm)
> to make the phy asserting the right delays, this is generally the
> preferred way to define the MAC <-> PHY connection.
>
> Signed-off-by: Uwe Kleine-König <ukleinek at debian.org>
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> Link: https://lore.kernel.org/r/20240304084612.711678-2-ukleinek@debian.org
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
>
> [ upstream commit: e8d45544f806f3b55c30345de84262cbb9504902 ]
>
> (cherry picked from commit e0bbe061fd537bd7b113c53eb046bbcbf0e6597d)
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> index 6c4269b3d95..20e4fa6c185 100644
> --- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> +++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
> @@ -198,15 +198,13 @@
>   	assigned-clock-rates = <0>, <125000000>;
>   	clock_in_out = "output";
>   	phy-handle = <&rgmii_phy0>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&gmac0_miim
>   		     &gmac0_tx_bus2
>   		     &gmac0_rx_bus2
>   		     &gmac0_rgmii_clk
>   		     &gmac0_rgmii_bus>;
> -	rx_delay = <0x2f>;
> -	tx_delay = <0x3c>;
>   	status = "okay";
>   };
>   


More information about the U-Boot mailing list