[PATCH 03/21] bloblist: test: doc: Move into the common suite

Tom Rini trini at konsulko.com
Tue Oct 29 17:36:42 CET 2024


On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 28 Oct 2024 at 20:33, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote:
> >
> > > There is no particular need for bloblist to have its own test suite.
> > > Move it into the common suite instead.
> > >
> > > Add the missing help for 'common' and update the docs.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > This feels both like churn and weird. I would think "common" tests are
> > for things that are kinda legacy and too catch-all to have their own
> > subgroup.
> 
> It's just chosen so that the test for common/ is in test/common - i.e.
> it makes it easier for people to find it.

Then I really don't understand renaming bloblist from something
descriptive to common which is not.

> BTW this series removes all tests from test/*.c and moves them into
> appropriate subdirs. Some of the tests are quite old so have just sat
> there all these years.

This is good, yes. But perhaps needs a bit more thought then about how
strong a mapping between filename/directory structure and test suite
name there needs to be.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241029/2ed5a225/attachment.sig>


More information about the U-Boot mailing list