[PATCH 03/21] bloblist: test: doc: Move into the common suite

[Simon Glass]

Hi Tom,

On Tue, 29 Oct 2024 at 17:36, Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote:
> > Hi Tom,
> >
> > On Mon, 28 Oct 2024 at 20:33, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote:
> > >
> > > > There is no particular need for bloblist to have its own test suite.
> > > > Move it into the common suite instead.
> > > >
> > > > Add the missing help for 'common' and update the docs.
> > > >
> > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > >
> > > This feels both like churn and weird. I would think "common" tests are
> > > for things that are kinda legacy and too catch-all to have their own
> > > subgroup.
> >
> > It's just chosen so that the test for common/ is in test/common - i.e.
> > it makes it easier for people to find it.
>
> Then I really don't understand renaming bloblist from something
> descriptive to common which is not.

Old: test/bloblist.c
New: test/common/bloblist.c

It is only the directory that is changing.

>
> > BTW this series removes all tests from test/*.c and moves them into
> > appropriate subdirs. Some of the tests are quite old so have just sat
> > there all these years.
>
> This is good, yes. But perhaps needs a bit more thought then about how
> strong a mapping between filename/directory structure and test suite
> name there needs to be.

OK so what do you suggest instead? This series was the result of my
thought about this :-)

Regards,
Simon