[PATCH 03/21] bloblist: test: doc: Move into the common suite

Tom Rini trini at konsulko.com
Thu Oct 31 19:10:49 CET 2024


On Thu, Oct 31, 2024 at 07:00:41PM +0100, Simon Glass wrote:
> Hi Tom,
> 
> On Tue, 29 Oct 2024 at 17:36, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Mon, 28 Oct 2024 at 20:33, Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote:
> > > >
> > > > > There is no particular need for bloblist to have its own test suite.
> > > > > Move it into the common suite instead.
> > > > >
> > > > > Add the missing help for 'common' and update the docs.
> > > > >
> > > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > >
> > > > This feels both like churn and weird. I would think "common" tests are
> > > > for things that are kinda legacy and too catch-all to have their own
> > > > subgroup.
> > >
> > > It's just chosen so that the test for common/ is in test/common - i.e.
> > > it makes it easier for people to find it.
> >
> > Then I really don't understand renaming bloblist from something
> > descriptive to common which is not.
> 
> Old: test/bloblist.c
> New: test/common/bloblist.c
> 
> It is only the directory that is changing.

Then some of the commit messages need to be reworked? It looks like it
stops being "ut bloblist" and part of "ut common" and that's my concern.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241031/8fc11827/attachment.sig>


More information about the U-Boot mailing list