[PATCH v1 04/20] arm: socfpga: agilex5: Add low level initialization

[Chee, Tien Fong]

Hi,

> -----Original Message-----
> From: Marek Vasut <marex at denx.de>
> Sent: Saturday, September 21, 2024 9:49 PM
> To: Chee, Tien Fong <tien.fong.chee at intel.com>; u-boot at lists.denx.de
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>; Meng, Tingting
> <tingting.meng at intel.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi at intel.com>; Hea, Kok Kiang
> <kok.kiang.hea at intel.com>
> Subject: Re: [PATCH v1 04/20] arm: socfpga: agilex5: Add low level
> initialization
> 
> On 9/20/24 9:02 AM, tien.fong.chee at intel.com wrote:
> > From: Tien Fong Chee <tien.fong.chee at intel.com>
> >
> > Create new low level initialization for Agile5 due to the new ARM core
> > composition and warm reset behavior.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > ---
> >   arch/arm/mach-socfpga/Makefile                |  1 +
> >   .../include/mach/reset_manager_soc64.h        | 12 +++-
> >   arch/arm/mach-socfpga/lowlevel_init_agilex5.S | 57
> +++++++++++++++++++
> >   3 files changed, 68 insertions(+), 2 deletions(-)
> >   create mode 100644 arch/arm/mach-socfpga/lowlevel_init_agilex5.S
> >
> > diff --git a/arch/arm/mach-socfpga/Makefile
> > b/arch/arm/mach-socfpga/Makefile index 67c6a8dfec5..53c91d1d2a5
> 100644
> > --- a/arch/arm/mach-socfpga/Makefile
> > +++ b/arch/arm/mach-socfpga/Makefile
> > @@ -58,6 +58,7 @@ endif
> >
> >   ifdef CONFIG_TARGET_SOCFPGA_AGILEX5
> >   obj-y	+= clock_manager_agilex5.o
> > +obj-y	+= lowlevel_init_agilex5.o
> >   obj-y	+= mailbox_s10.o
> >   obj-y	+= misc_soc64.o
> >   obj-y	+= mmu-arm64_s10.o
> Can this be wired into existing early hook function, like s_init or so ?

I cannot find the caller for s_init, wonder where is the s_init is called?
What's concern with lowlevel_init()? It's also wired into existing early hook function which's located inside start.S

Regards,
Tien Fong.