[PATCH v2 2/3] video: rockchip: rk3328: filter unsupported modes

[Vasily Khoruzhick]

On Sun, Mar 30, 2025 at 4:57 AM Jonas Karlman <jonas at kwiboo.se> wrote:
>
> Hi Vasily,

> > +     /* Limit pixel clock to 297MHz. While RK3328 support higher rates and it
> > +      * works in Linux, it doesn't seem to work in u-boot. That limits max
> > +      * resolution to 1440p
> > +      */
> > +     return timing->pixelclock.typ <= 297000000;
>
> I think it make more sense to limit to the HDMI 1.4 max 340 MHz instead
> of arbitrary 297 MHz. Anything above 340 MHz will require scrambling etc
> and will not work in U-Boot unless at least dw-hdmi driver is updated.

Sure, sounds reasonable. Will do in v3.

> Regards,
> Jonas
>
> > +}
> > +
> >  static const struct dm_display_ops rk3328_hdmi_ops = {
> >       .read_edid = rk_hdmi_read_edid,
> >       .enable = rk3328_hdmi_enable,
> > +     .mode_valid = rk3328_hdmi_mode_valid,
> >  };
> >
> >  static const struct udevice_id rk3328_hdmi_ids[] = {
>