RISC-V UEFI/ACPI on QEMU regression?

[Ilias Apalodimas]

On Wed, 2 Apr 2025 at 18:26, Björn Töpel <bjorn at kernel.org> wrote:
>
> Hey!
>
> On Wed, 2 Apr 2025 at 16:27, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > Hey Bjorn
> >
> > Long time, hope all is well!
>
> Too long! Maybe next Plumbers? ;-)

One can only hope!

>
> > I think it's a regression and I think what breaks it is commit cfb4aa2a754ed1
> >
> > Can you apply the diff below and see if it fixes it for you?
> >
> > diff --git a/lib/efi_loader/efi_acpi.c b/lib/efi_loader/efi_acpi.c
> > index 4422b31ac6a7..afa5eee85484 100644
> > --- a/lib/efi_loader/efi_acpi.c
> > +++ b/lib/efi_loader/efi_acpi.c
> > @@ -34,8 +34,8 @@ efi_status_t efi_acpi_register(void)
> >          * add_u_boot_and_runtime(). At some point that function could create a
> >          * more detailed map.
> >          */
> > -       if (IS_ENABLED(CONFIG_BLOBLIST_TABLES))
> > -               return EFI_SUCCESS;
> > +       //if (IS_ENABLED(CONFIG_BLOBLIST_TABLES))
> > +               ////return EFI_SUCCESS;
> >
> >         /* Mark space used for tables */
> >         start = ALIGN_DOWN(gd->arch.table_start, EFI_PAGE_MASK);
>
> Unfortunately, still the same with this patch:

Yea, I skimmed that too quickly ...

Can you try this though?

diff --git a/drivers/misc/qfw_acpi.c b/drivers/misc/qfw_acpi.c
index 0d0cf7646890..77cebae5e3fd 100644
--- a/drivers/misc/qfw_acpi.c
+++ b/drivers/misc/qfw_acpi.c
@@ -305,7 +305,7 @@ static int evt_write_acpi_tables(void)
        /* Generate ACPI tables */
        end = write_acpi_tables(addr);
        gd->arch.table_start = addr;
-       gd->arch.table_end = addr;
+       gd->arch.table_end = end;

        return 0;
 }

Thanks
/Ilias
>
> [    0.000000] efi:   0x00047eee3000-0x00047ef19fff [Boot Code   |   |
>  |  |  |  |  |  |  |  |  |   |WB|  |  |  ]
> [    0.000000] efi:   0x00047ef1a000-0x00047ef49fff [ACPI Reclaim|   |
>  |  |  |  |  |  |  |  |  |   |WB|  |  |  ]
> [    0.000000] ACPI: RSDP 0x000000047EED1000 000024 (v02 BOCHS )
>
> (RSDP resides in Boot Code)
>
>
> Björn