[PATCH] rockchip: io-domain: Enable by default for all supported SoCs

Kever Yang kever.yang at rock-chips.com
Sun Apr 6 17:39:53 CEST 2025


Hi Chen-Yu,

On 2025/4/1 15:31, Chen-Yu Tsai wrote:
> On Tue, Apr 1, 2025 at 3:22 PM Anand Moon <linux.amoon at gmail.com> wrote:
>> Hi Kever,
>>
>> On Tue, 1 Apr 2025 at 09:11, Anand Moon <linux.amoon at gmail.com> wrote:
>>> Hi Kever,
>>>
>>> On Tue, 1 Apr 2025 at 08:30, Kever Yang <kever.yang at rock-chips.com> wrote:
>>>> Hi Anand,
>>>>
>>>> On 2025/3/30 21:33, Anand Moon wrote:
>>>>> Hi Chen-Yu
>>>>>
>>>>> On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens at kernel.org> wrote:
>>>>>> From: Chen-Yu Tsai <wens at csie.org>
>>>>>>
>>>>>> The IO domain driver controls the I/O voltage for various pins,
>>>>>> MMC included.
>>>>>>
>>>>>> Enable it by default for all supported Rockchip SoCs.
>>>>>>
>>>>>> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
>>>>> Reviewed-by: Anand Moon <linux.amoon at gmail.com>
>>>>>
>>>>> Can we enable following config default for all the boards
>>>>>
>>>>> CONFIG_MMC_DW=y
>>>>> CONFIG_MMC_DW_ROCKCHIP=y
>>>>> CONFIG_MMC_SDHCI=y
>>>> These two driver, SD card and eMMC, are board specific, not all the
>>>> board has enable all these two interface.
>>>>
>>> Ok,I thought it should reduce the configuration options on all the boards.
>> But can we implement this for each SoC, such as the RK3399 and RK3588?"
> Of all the defconfigs that have ARCH_ROCKCHIP, only three don't have MMC_DW:
>
>      configs/coolpi-cm5-genbook-rk3588_defconfig
>      configs/evb-rv1108_defconfig
>      configs/geekbox_defconfig
>
> So maybe we could have the default by y, and negate the option where
> it makes sense.

Yes, sounds reasonable for DW MMC, both SD and eMMC use this controller 
for legacy SoCs.

For new SoCs, the eMMC is using MMC_SDHCI, and maybe more boards does 
not enable it.


Thanks,
- Kever
>
> For MMC_SDHCI there would be more defconfigs, but only a couple SoCs
> support this controller, and we could narrow it down to those.
>
>
> ChenYu
>


More information about the U-Boot mailing list