[PATCH v2 6/7] configs: rockchip: Enable ethernet driver on RK356x boards

[Jonas Karlman]

Hi Diederik,

On 2025-04-06 22:09, Diederik de Haas wrote:
> Hi,
> 
> On Thu Jul 11, 2024 at 9:38 PM CEST, Diederik de Haas wrote:
>> Some time ago I reported to Jonas privately that I had a problem with
>> my Quartz64 Model A and B and that I bisected it to this commit.
>> I just verified that the problem is still present in 2024.07, so I
>> guess it's time to report it to the (right) Mailing List.
>>
>> The problem: packet loss, varying, but sometimes massive
>> Q64-A: The packet loss was usually between 8% and 30%
>> Q64-B: Packet loss up to 80% sometimes and this also resulted (then) in
>> its inability to receive a DHCP address.
> 
> I just build a ~2025.04-rc5 (i.e. 'master') version and tried it on my
> Q64-B and the problem is still there.
> Furthermore, there have now been several ppl on #quartz64 IRC channel
> (on Pine64 IRC network) who have confirmed both the problem and the
> 'solution'/workaround. Hopefully they'll also report here themselves.

I did a quick test on my Q64-A and can confirm it sometime behaves
strange when Ethernet has been initialized in U-Boot.

At times my iperf3 test report ~0-1 Mbits/sec instead of the more normal
~941 Mbits/sec. After one (or more) "ifconfig eth0 down/up" cycle
everything seemed to work okay again. However after one (or more) eth0
down/up cycle the retries was no longer 0 and speed could instead be
~0-1 Mbits/sec.

I will see if I can replicate this on other rk3566 boards beside Q64.

Can you please try one or more "ifconfig eth0 down/up" cycle and see if
that improves your packet loss issue?

Regards,
Jonas

> 
>> And the fix in my case has always been easy:
>>
>> diff --git a/configs/quartz64-a-rk3566_defconfig b/configs/quartz64-a-rk3566_defconfig
>> index 1ea8e0f40cc..641452f9162 100644
>> --- a/configs/quartz64-a-rk3566_defconfig
>> +++ b/configs/quartz64-a-rk3566_defconfig
>> @@ -67,9 +67,6 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y
>>  CONFIG_SPI_FLASH_GIGADEVICE=y
>>  CONFIG_SPI_FLASH_MACRONIX=y
>>  CONFIG_SPI_FLASH_WINBOND=y
>> -CONFIG_PHY_MOTORCOMM=y
>> -CONFIG_DWC_ETH_QOS=y
>> -CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>>  CONFIG_NVME_PCI=y
>>  CONFIG_PCIE_DW_ROCKCHIP=y
>>  CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>> diff --git a/configs/quartz64-b-rk3566_defconfig b/configs/quartz64-b-rk3566_defconfig
>> index f61b2c181a1..aae5d66edeb 100644
>> --- a/configs/quartz64-b-rk3566_defconfig
>> +++ b/configs/quartz64-b-rk3566_defconfig
>> @@ -65,9 +65,6 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y
>>  CONFIG_SPI_FLASH_GIGADEVICE=y
>>  CONFIG_SPI_FLASH_MACRONIX=y
>>  CONFIG_SPI_FLASH_WINBOND=y
>> -CONFIG_PHY_REALTEK=y
>> -CONFIG_DWC_ETH_QOS=y
>> -CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>>  CONFIG_NVME_PCI=y
>>  CONFIG_PCIE_DW_ROCKCHIP=y
>>  CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>>
>> IOW: a (partial) revert of commit 25f56459aebc
> 
> I didn't try it this time; I just dd-ed my patched 2024.07 version and
> then everything worked again.
> 
> It would be nice to get this fixed. I don't know how to fix it myself,
> but I'm happy to test a potential patch for it.
> 
> Cheers,
>   Diederik