[PATCH 3/5] arm64: versal: fix dfu alt buffer clearing
Vincent Stehlé
vincent.stehle at arm.com
Mon Apr 7 19:05:27 CEST 2025
The set_dfu_alt_info() function calls the ALLOC_CACHE_ALIGN_BUFFER()
macro to declare a `buf' variable pointer into an array allocated on the
stack. It then calls the memset() function to clear the useable portion
of the array using the idiomatic expression `sizeof(buf)'.
While this would indeed work fine for an array, in the present case we
end up clearing only the size of a pointer.
Fix this by specifying the explicit size `DFU_ALT_BUF_LEN' instead.
Fixes: 064c8978b44f ("arm64: versal: Enable capsule update (SD)")
Signed-off-by: Vincent Stehlé <vincent.stehle at arm.com>
Cc: Michal Simek <michal.simek at amd.com>
Cc: Tom Rini <trini at konsulko.com>
---
board/xilinx/versal/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c
index b4483d00ad1..3edccc979d8 100644
--- a/board/xilinx/versal/board.c
+++ b/board/xilinx/versal/board.c
@@ -396,7 +396,7 @@ void set_dfu_alt_info(char *interface, char *devstr)
if (env_get("dfu_alt_info"))
return;
- memset(buf, 0, sizeof(buf));
+ memset(buf, 0, DFU_ALT_BUF_LEN);
multiboot = env_get_hex("multiboot", multiboot);
--
2.47.2
More information about the U-Boot
mailing list