[PATCH 07/13] board: dragonboard410c: Use dynamically allocated load addresses

Neil Armstrong neil.armstrong at linaro.org
Mon Apr 7 20:08:33 CEST 2025


On 07/04/2025 18:59, Stephan Gerhold wrote:
> The generic Qualcomm board code allocates addresses for loading the kernel,
> ramdisk, DT, fastboot etc. This also happens on the DB410c and already
> overrides these definitions defined in the default env. So let's just drop
> the static ones, since the dynamic ones work just fine.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold at linaro.org>
> ---
>   board/qualcomm/dragonboard410c/dragonboard410c.c   | 2 +-
>   board/qualcomm/dragonboard410c/dragonboard410c.env | 8 +-------
>   2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c
> index 61d68e7f0c6bed16861e6ceaefd2c7dc94807d65..697e3c9b08b5c874912eb66ff4f0b3d32deaae01 100644
> --- a/board/qualcomm/dragonboard410c/dragonboard410c.c
> +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c
> @@ -66,7 +66,7 @@ int misc_init_r(void)
>   
>   	state = button_get_state(btn);
>   	if (state == BUTTON_ON) {
> -		env_set("preboot", "setenv preboot; fastboot 0");
> +		env_set("preboot", "setenv preboot; run fastboot");
>   		printf("vol_down pressed - Starting fastboot.\n");
>   	}
>   
> diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.env b/board/qualcomm/dragonboard410c/dragonboard410c.env
> index eb42c0abcf11fedf7ab86d1340531b4ff5b52bf5..0032dc3592a1021e4bb422357867cc26b4b30551 100644
> --- a/board/qualcomm/dragonboard410c/dragonboard410c.env
> +++ b/board/qualcomm/dragonboard410c/dragonboard410c.env
> @@ -1,9 +1,3 @@
>   /* SPDX-License-Identifier: GPL-2.0+ */
> -loadaddr=0x81000000
>   initrd_high=0xffffffffffffffff
> -kernel_addr_r=0x81000000
> -fdtfile=qcom/apq8016-sbc.dtb
> -fdt_addr_r=0x83000000
> -ramdisk_addr_r=0x84000000
> -scriptaddr=0x90000000
> -pxefile_addr_r=0x90100000
> +fastboot=fastboot -l $fastboot_addr_r usb 0
> 

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the U-Boot mailing list