[PATCH 01/14] pinctrl: rockchip: remove unused base_pin bank member

Kever Yang kever.yang at rock-chips.com
Tue Apr 8 04:26:37 CEST 2025


On 2025/1/29 20:42, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz at cherry.de>
>
> Each bank has a base_pin member that is only set in the core and never
> used, so it can be removed.
>
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 1 -
>   drivers/pinctrl/rockchip/pinctrl-rockchip.h      | 2 --
>   2 files changed, 3 deletions(-)
>
> diff --git a/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c b/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c
> index d449d07d32e74d1dec1978b1405bec94887908a2..7369fe12b961290742f6ba24fb32b768531f56f9 100644
> --- a/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c
> +++ b/drivers/pinctrl/rockchip/pinctrl-rockchip-core.c
> @@ -543,7 +543,6 @@ static struct rockchip_pin_ctrl *rockchip_pinctrl_get_soc_data(struct udevice *d
>   		int bank_pins = 0;
>   
>   		bank->priv = priv;
> -		bank->pin_base = ctrl->nr_pins;
>   		ctrl->nr_pins += bank->nr_pins;
>   
>   		/* calculate iomux and drv offsets */
> diff --git a/drivers/pinctrl/rockchip/pinctrl-rockchip.h b/drivers/pinctrl/rockchip/pinctrl-rockchip.h
> index df7bc684d29fae4ec650d1e14fe88b35b03244ac..ebd008eede24af32c123634a57f50c0294e76842 100644
> --- a/drivers/pinctrl/rockchip/pinctrl-rockchip.h
> +++ b/drivers/pinctrl/rockchip/pinctrl-rockchip.h
> @@ -262,7 +262,6 @@ struct rockchip_drv {
>   
>   /**
>    * @priv: common pinctrl private basedata
> - * @pin_base: first pin number
>    * @nr_pins: number of pins in this bank
>    * @name: name of the bank
>    * @bank_num: number of the bank, to account for holes
> @@ -274,7 +273,6 @@ struct rockchip_drv {
>    */
>   struct rockchip_pin_bank {
>   	struct rockchip_pinctrl_priv	*priv;
> -	u32				pin_base;
>   	u8				nr_pins;
>   	char				*name;
>   	u8				bank_num;
>


More information about the U-Boot mailing list