[PATCH] net: dhcpv6: remove excluded middle expression

Jerome Forissier jerome.forissier at linaro.org
Wed Apr 9 16:20:36 CEST 2025


Hi Bryan,

On 4/8/25 23:57, Bryan Brattlof wrote:
>  !A || (A && B) is equivalent to !A || B
> 
> Drop the middle expression from the statement
> 
> Signed-off-by: Bryan Brattlof <bb at ti.com>
> ---
>  net/dhcpv6.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/dhcpv6.c b/net/dhcpv6.c
> index 54619ee698362..65ec48ef665e5 100644
> --- a/net/dhcpv6.c
> +++ b/net/dhcpv6.c
> @@ -473,8 +473,7 @@ static int dhcp6_check_advertise_packet(uchar *rx_pkt, unsigned int len)
>  		 * server UID, save the new server UID and preference
>  		 */
>  		if (!sm_params.server_uid.uid_ptr ||
> -		    (sm_params.server_uid.uid_ptr &&
> -		    sm_params.server_uid.preference < sm_params.rx_status.preference)) {
> +		    sm_params.server_uid.preference < sm_params.rx_status.preference) {
>  			rx_uid_size = sm_params.rx_status.server_uid_size;
>  			if (sm_params.server_uid.uid_ptr)
>  				free(sm_params.server_uid.uid_ptr);

Reviewed-by: Jerome Forissier <jerome.forissier at linaro.org>

Thanks,
-- 
Jerome


More information about the U-Boot mailing list